Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750781AbdLZGwu (ORCPT ); Tue, 26 Dec 2017 01:52:50 -0500 Received: from mail-eopbgr00043.outbound.protection.outlook.com ([40.107.0.43]:51552 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750705AbdLZGwt (ORCPT ); Tue, 26 Dec 2017 01:52:49 -0500 From: Peng Fan To: Shawn Guo CC: "A.s. Dong" , "linux-kernel@vger.kernel.org" , Russell King , "Fabio Estevam" , Sascha Hauer , "van.freenix@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Thread-Topic: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Thread-Index: AQHTca+I9uQpoIijsECS1wrrCngHnKNVEKUAgAA3wQA= Date: Tue, 26 Dec 2017 06:52:45 +0000 Message-ID: References: <20171210120718.15197-1-peng.fan@nxp.com> <20171226033125.GA4210@X250> In-Reply-To: <20171226033125.GA4210@X250> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-originating-ip: [92.121.68.129] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AMSPR04MB310;6:L3flwJXJyn53pQLSk5b+P//tCxtUzk1mkEKOm9dBN1E0l2dqhOwPPBgSIaVTmGFc5exEX/BWil7Img9OrEy5G+5aF3syxqGMzob+5D7ATaoAJZbSXJ/1HyQLWowz+EI32puUzt1IOZN58pwJnM/oRvyZ1V3I3J1tZdBLMEl0QJDnUBqkrNzvVYHtathqAxIQmc0/br/oXNwjZlxjDrKVZR7GIPB0RDQU7d5WLX9nDhMutROqURiw6uY+o99YKBO0ihY+Z5simEk0mzQ9xZPWEb1GuYJbbKkcOwFCSmesDn/e0wLDPdfa1jIyxYK2uZSuu1u6sjpqF6nFRpMZXUAfFPZOBjGnm9+mLmcd6PDR2/G6jKzMlZ/Mp2vjRGRGPc3m;5:sNYdXJ0pceS9USPIGl474Xf6bSSmSDBS5rFtlyI5wEPnSWY6AR8sPcPBz7EfQYwsIZpgYnUB59cUDR8tMlQr62Pp2B9W44l5SJHysLHUOl5YSeSTh9eUsryYCmBTi8VVsRTzkykSP8am8hsqbWo63emH+oCf9pYBS8hQYxsH5Ws=;24:gEECr28C6yoX+bc7wLo5R92NkIPKmDDLerm4gkAHLKOzOVKG+eaQvqL3bWJIkxVWwe9zKG6uad0Ib+YU5gvkgjOB4SVfFRYayIJUVUyWEpk=;7:9jt4CDG970ruxj1kZaZ8Tsn1iM1U2qtkgXe//EQzlrEGPDvWdRgy7LAHjIgj0jmLPolZhQc8eo1PLxLal0U/g1ApqXvtWLBBtxiTh+lD0KjBcJ7JEmCEm3pJU8OQ/IGuz2phNjtQItnNLLOS4Gl9aKAXdTLsPdZJxFCE40RlG+PJcEJ1NN13akfKXnPU11oVCj7DmvT/nUH8lIFaK2vaUzNlC8DTiOt4N8FU8AAk0CE+6G0WsB62p4uQT0rfpZcY x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(39380400002)(346002)(376002)(39860400002)(396003)(366004)(199004)(189003)(13464003)(24454002)(6116002)(2900100001)(3846002)(105586002)(68736007)(106356001)(53546011)(6506007)(66066001)(74316002)(86362001)(7736002)(33656002)(305945005)(5250100002)(59450400001)(4326008)(2906002)(81166006)(316002)(6436002)(14454004)(39060400002)(229853002)(25786009)(15650500001)(81156014)(8676002)(3280700002)(5660300001)(99286004)(3660700001)(6916009)(55016002)(54906003)(102836004)(53936002)(7696005)(9686003)(6246003)(478600001)(76176011)(8936002)(2950100002)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR04MB310;H:DB6PR04MB3221.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: a9f716fa-d441-4396-f552-08d54c2d44c2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060);SRVR:AMSPR04MB310; x-ms-traffictypediagnostic: AMSPR04MB310: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041268)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011);SRVR:AMSPR04MB310;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR04MB310; x-forefront-prvs: 053315510E x-microsoft-antispam-message-info: S9Lejrm9xmBKx4R9kKGmcaSuDGBHIHs+ZBiHm8yQ/X9uxQCQyG1bxESqqQl/2WkUxCSlYJd1oATz5xbVZDFafQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9f716fa-d441-4396-f552-08d54c2d44c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2017 06:52:45.2722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR04MB310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBQ6qu0S006303 Content-Length: 1418 Lines: 39 Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Tuesday, December 26, 2017 11:31 AM > To: Peng Fan > Cc: A.s. Dong ; linux-kernel@vger.kernel.org; Russell > King ; Fabio Estevam ; > Sascha Hauer ; van.freenix@gmail.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume > > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote: > > Use outer_disable/resume for suspend/resume. > > With the two APIs used, code could be simplified and easy to extend to > > introduce l2c_write_sec for i.MX platforms when moving Linux Kernel > > runs in non-secure world. > > > > Signed-off-by: Peng Fan > > Cc: Shawn Guo > > Cc: Sascha Hauer > > Cc: Fabio Estevam > > Cc: Russell King > > Cc: Dong Aisheng > > --- > > arch/arm/mach-imx/pm-imx6.c | 2 ++ > > arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------ > > I'm fine with the patch in general. But this piece of code is running on a few > i.MX6 platforms, and I'm wondering on which SoCs you have verified the > change work fine. I tested it on 6Q-SDB board. Is it ok? Thanks, Peng. > > Shawn