Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750847AbdLZJJJ (ORCPT ); Tue, 26 Dec 2017 04:09:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:56146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbdLZJJI (ORCPT ); Tue, 26 Dec 2017 04:09:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DCCF218BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Tue, 26 Dec 2017 17:09:03 +0800 From: Shawn Guo To: Peng Fan Cc: "A.s. Dong" , "linux-kernel@vger.kernel.org" , Russell King , "van.freenix@gmail.com" , Sascha Hauer , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Message-ID: <20171226090902.GO23070@X250> References: <20171210120718.15197-1-peng.fan@nxp.com> <20171226033125.GA4210@X250> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 38 On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote: > Hi Shawn, > > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: Tuesday, December 26, 2017 11:31 AM > > To: Peng Fan > > Cc: A.s. Dong ; linux-kernel@vger.kernel.org; Russell > > King ; Fabio Estevam ; > > Sascha Hauer ; van.freenix@gmail.com; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume > > > > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote: > > > Use outer_disable/resume for suspend/resume. > > > With the two APIs used, code could be simplified and easy to extend to > > > introduce l2c_write_sec for i.MX platforms when moving Linux Kernel > > > runs in non-secure world. > > > > > > Signed-off-by: Peng Fan > > > Cc: Shawn Guo > > > Cc: Sascha Hauer > > > Cc: Fabio Estevam > > > Cc: Russell King > > > Cc: Dong Aisheng > > > --- > > > arch/arm/mach-imx/pm-imx6.c | 2 ++ > > > arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------ > > > > I'm fine with the patch in general. But this piece of code is running on a few > > i.MX6 platforms, and I'm wondering on which SoCs you have verified the > > change work fine. > > I tested it on 6Q-SDB board. Is it ok? Okay, I will get it into linux-next for a bit wider testing. Shawn