Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751012AbdLZJSS (ORCPT ); Tue, 26 Dec 2017 04:18:18 -0500 Received: from mail-he1eur01on0087.outbound.protection.outlook.com ([104.47.0.87]:5289 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750781AbdLZJSR (ORCPT ); Tue, 26 Dec 2017 04:18:17 -0500 From: Peng Fan To: Shawn Guo CC: "A.s. Dong" , "linux-kernel@vger.kernel.org" , Russell King , "van.freenix@gmail.com" , Sascha Hauer , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Thread-Topic: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Thread-Index: AQHTca+I9uQpoIijsECS1wrrCngHnKNVEKUAgAA3wQCAACaUgIAAAg7g Date: Tue, 26 Dec 2017 09:18:12 +0000 Message-ID: References: <20171210120718.15197-1-peng.fan@nxp.com> <20171226033125.GA4210@X250> <20171226090902.GO23070@X250> In-Reply-To: <20171226090902.GO23070@X250> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@nxp.com; x-originating-ip: [92.121.68.129] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB4PR04MB314;7:7WLFNnXOV/JRCcszkiQn8deHUqJwDXdt6zghswsi/+6D3FsAW82/ucJf9m0BCxZRWpLQmRQlgd5CoOhdFuhAcG4o9+HzTpZKHXzZFLFven/R/g/yG3s6edOds+J+pgGjFJvdwFJFkJFw9tyo98F82Oe5y0rjxPUZfRlI9c//3CaXiHsqd9xvokdrBAGCHXleIksSmxX3Fn1GLSx7ullucErk0onfuTkzLZs3YsfVD1PanJvvdiSysR/1BBEn+DVm x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(39380400002)(366004)(376002)(39860400002)(396003)(346002)(199004)(24454002)(189003)(13464003)(3280700002)(3660700001)(106356001)(14454004)(81156014)(966005)(33656002)(229853002)(8676002)(6916009)(2950100002)(3846002)(6116002)(53936002)(2906002)(86362001)(5660300001)(5250100002)(97736004)(105586002)(102836004)(54906003)(7736002)(76176011)(6306002)(81166006)(59450400001)(4326008)(7696005)(6246003)(55016002)(39060400002)(6506007)(53546011)(9686003)(8936002)(2900100001)(25786009)(15650500001)(478600001)(6436002)(66066001)(305945005)(74316002)(99286004)(68736007)(316002)(93886005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR04MB314;H:DB6PR04MB3221.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: e28ea7d8-63ab-403a-5155-08d54c419696 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060);SRVR:DB4PR04MB314; x-ms-traffictypediagnostic: DB4PR04MB314: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231023)(944501075)(6055026)(6041268)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:DB4PR04MB314;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB4PR04MB314; x-forefront-prvs: 053315510E x-microsoft-antispam-message-info: WxfbqHNncFzDAXvEBr6ve02TrPHNiNKOGuLSvYMJCnwRmbHXOyD/4Y7ui9WCSsZfR7TMvSYh9sw3nZJeLGRnRg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e28ea7d8-63ab-403a-5155-08d54c419696 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2017 09:18:12.4718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB314 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBQ9IM5O019012 Content-Length: 2332 Lines: 61 Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Tuesday, December 26, 2017 5:09 PM > To: Peng Fan > Cc: A.s. Dong ; linux-kernel@vger.kernel.org; Russell > King ; van.freenix@gmail.com; Sascha Hauer > ; Fabio Estevam ; linux- > arm-kernel@lists.infradead.org > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume > > On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote: > > Hi Shawn, > > > > > -----Original Message----- > > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > > Sent: Tuesday, December 26, 2017 11:31 AM > > > To: Peng Fan > > > Cc: A.s. Dong ; linux-kernel@vger.kernel.org; > > > Russell King ; Fabio Estevam > > > ; Sascha Hauer ; > > > van.freenix@gmail.com; linux-arm- kernel@lists.infradead.org > > > Subject: Re: [PATCH] arm: imx: suspend/resume: use > > > outer_disable/resume > > > > > > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote: > > > > Use outer_disable/resume for suspend/resume. > > > > With the two APIs used, code could be simplified and easy to > > > > extend to introduce l2c_write_sec for i.MX platforms when moving > > > > Linux Kernel runs in non-secure world. > > > > > > > > Signed-off-by: Peng Fan > > > > Cc: Shawn Guo > > > > Cc: Sascha Hauer > > > > Cc: Fabio Estevam > > > > Cc: Russell King > > > > Cc: Dong Aisheng > > > > --- > > > > arch/arm/mach-imx/pm-imx6.c | 2 ++ > > > > arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------ > > > > > > I'm fine with the patch in general. But this piece of code is > > > running on a few > > > i.MX6 platforms, and I'm wondering on which SoCs you have verified > > > the change work fine. > > > > I tested it on 6Q-SDB board. Is it ok? > > Okay, I will get it into linux-next for a bit wider testing. Thanks. I missed to note that, I applied this patch in my testing https://www.spinics.net/lists/arm-kernel/msg623610.html to avoid suspicious RCU usage. Thanks, Peng. > > Shawn