Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbdLZN0F (ORCPT ); Tue, 26 Dec 2017 08:26:05 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36444 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbdLZN0D (ORCPT ); Tue, 26 Dec 2017 08:26:03 -0500 X-Google-Smtp-Source: ACJfBou2PpIK1AeAKAqSFAtcS/tY53O9xHRh92sDOd+gJcXYKj4IuHZfr+Q6JWJdFwBjHHR86Y/lWA== From: Mathieu Malaterre Cc: Mathieu Malaterre , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Balbir Singh , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/xmon: Do not compute/store the major opcode Date: Tue, 26 Dec 2017 14:25:47 +0100 Message-Id: <20171226132548.22177-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 33 In commit 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation changes)") usage of variable `op` has been removed. Completely remove opcode computation since not used anymore. Fix fatal warning: arch/powerpc/xmon/ppc-dis.c: In function ‘lookup_powerpc’: arch/powerpc/xmon/ppc-dis.c:96:17: error: variable ‘op’ set but not used [-Werror=unused-but-set-variable] unsigned long op; ^~ Signed-off-by: Mathieu Malaterre --- arch/powerpc/xmon/ppc-dis.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/xmon/ppc-dis.c b/arch/powerpc/xmon/ppc-dis.c index 31db8c072acd..9deea5ee13f6 100644 --- a/arch/powerpc/xmon/ppc-dis.c +++ b/arch/powerpc/xmon/ppc-dis.c @@ -93,10 +93,6 @@ lookup_powerpc (unsigned long insn, ppc_cpu_t dialect) { const struct powerpc_opcode *opcode; const struct powerpc_opcode *opcode_end; - unsigned long op; - - /* Get the major opcode of the instruction. */ - op = PPC_OP (insn); opcode_end = powerpc_opcodes + powerpc_num_opcodes; /* Find the first match in the opcode table for this major opcode. */ -- 2.11.0