Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750977AbdLZPFx (ORCPT ); Tue, 26 Dec 2017 10:05:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:47504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdLZPFw (ORCPT ); Tue, 26 Dec 2017 10:05:52 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8A9321891 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 26 Dec 2017 12:05:49 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Malaterre Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration Message-ID: <20171226150549.GW21971@kernel.org> References: <20171226140913.16640-1-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171226140913.16640-1-malat@debian.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 32 Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: > Fix non-fatal warning: > > kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > static void __always_inline > ^~~~~~ Can you please provide more context? When did this become a problem? What gcc version? - Arnaldo > Signed-off-by: Mathieu Malaterre > --- > kernel/events/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 4df5b695bf0d..aa874d2b58b3 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, > data->phys_addr = perf_virt_to_phys(data->addr); > } > > -static void __always_inline > +static __always_inline void > __perf_event_output(struct perf_event *event, > struct perf_sample_data *data, > struct pt_regs *regs, > -- > 2.11.0