Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbdLZRQ6 convert rfc822-to-8bit (ORCPT ); Tue, 26 Dec 2017 12:16:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:43032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdLZRQ4 (ORCPT ); Tue, 26 Dec 2017 12:16:56 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44B952191C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: ACJfBouJd7h6UF319xC3/pMTrdS483wWg84Hlmyzo79CorRKZKcMwqPUYe7uYj6Zfvzq3rtto4ylL1RgYjXbWBGGP0k= MIME-Version: 1.0 In-Reply-To: <20171222105642.GD18255@piout.net> References: <95F51F4B902CAC40AF459205F6322F01B7FDFECC3C@BMK019S01.emtrion.local> <20171222104028.GC18255@piout.net> <20171222105642.GD18255@piout.net> From: Rob Herring Date: Tue, 26 Dec 2017 11:16:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series To: Alexandre Belloni Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , Philippe Ombredanne , =?UTF-8?B?VMO8cmssIEphbg==?= , Mark Rutland , Thierry Reding , David Airlie , Russell King , Shawn Guo , Sascha Hauer , Fabio Estevam , Kevin Hilman , Maxime Ripard , SZ Lin , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , LinuxArmKernelMailingListe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 37 On Fri, Dec 22, 2017 at 4:56 AM, Alexandre Belloni wrote: > + Philippe > > On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote: >> >> I'll change it for v3 of this patch however it will end up like this: >> >> //SPDX-License... >> > >> > That should be /* SPDX-License */, // is for c files. >> >> Got any reference for that? Since we're using the C preprocessor before >> feeding them to dtc, we can use the same // style for both, builds fine. >> >> Only for my private DT overlay files that I use directly with dtc I >> couldn't adopt that style. We are well past the point of being able to build most dts files with just dtc. > The doc states: > > If a specific tool cannot handle the standard comment style, then the > appropriate comment mechanism which the tool accepts shall be used. This > is the reason for having the "/\* \*/" style comment in C header > files. > > I interpreted that as dtc doesn't handle // comments, use /**/ It's been so long, I'd forgotten that. Perhaps we should fix dtc to handle // comments. > > But I agree it also states: > .dts{i}: // SPDX-License-Identifier: Or we could still change this. The guidelines aren't merged yet. Rob