Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751287AbdLZRmQ (ORCPT ); Tue, 26 Dec 2017 12:42:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:46648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdLZRmP (ORCPT ); Tue, 26 Dec 2017 12:42:15 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29DB42192B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: ACJfBosC41fQ85R42IG042vmALcAJd7x+cnSOhzdwcYexRcEOXzNiv5ofh88toUIfAlWq7goAIitwFObYuAkSZR7iTk= MIME-Version: 1.0 In-Reply-To: References: <2b8dd58f9d6dae7f0fa04694e8147524be9300ea.1514267721.git.arvind.yadav.cs@gmail.com> From: Krzysztof Kozlowski Date: Tue, 26 Dec 2017 18:42:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/11 v2] ARM: s3c24xx/s3c64xx: constify gpio_led To: Arvind Yadav Cc: nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, kaloz@openwrt.org, khalasa@piap.pl, aaro.koskinen@iki.fi, tony@atomide.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, daniel@zonque.org, haojian.zhuang@gmail.com, marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk, kgene@kernel.org, ralf@linux-mips.org, ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4067 Lines: 104 On Tue, Dec 26, 2017 at 7:37 AM, Arvind Yadav wrote: > Signed-off-by: Arvind Yadav Please write one-sentence long, easy to understand message describing the change. Best regards, Krzysztof > --- > changes in v2: > The GPIO LED driver can be built as a module, it can > be loaded after the init sections have gone away. > So removed '__initconst'. > > arch/arm/mach-s3c24xx/mach-h1940.c | 2 +- > arch/arm/mach-s3c24xx/mach-rx1950.c | 2 +- > arch/arm/mach-s3c64xx/mach-hmt.c | 2 +- > arch/arm/mach-s3c64xx/mach-smartq5.c | 2 +- > arch/arm/mach-s3c64xx/mach-smartq7.c | 2 +- > arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c > index 7ed7861..6a3e0e6 100644 > --- a/arch/arm/mach-s3c24xx/mach-h1940.c > +++ b/arch/arm/mach-s3c24xx/mach-h1940.c > @@ -413,7 +413,7 @@ int h1940_led_blink_set(struct gpio_desc *desc, int state, > } > EXPORT_SYMBOL(h1940_led_blink_set); > > -static struct gpio_led h1940_leds_desc[] = { > +static const struct gpio_led h1940_leds_desc[] = { > { > .name = "Green", > .default_trigger = "main-battery-full", > diff --git a/arch/arm/mach-s3c24xx/mach-rx1950.c b/arch/arm/mach-s3c24xx/mach-rx1950.c > index e86ad6a..97bb6a5 100644 > --- a/arch/arm/mach-s3c24xx/mach-rx1950.c > +++ b/arch/arm/mach-s3c24xx/mach-rx1950.c > @@ -295,7 +295,7 @@ static int rx1950_led_blink_set(struct gpio_desc *desc, int state, > return 0; > } > > -static struct gpio_led rx1950_leds_desc[] = { > +static const struct gpio_led rx1950_leds_desc[] = { > { > .name = "Green", > .default_trigger = "main-battery-full", > diff --git a/arch/arm/mach-s3c64xx/mach-hmt.c b/arch/arm/mach-s3c64xx/mach-hmt.c > index 59b5531..f8d644f 100644 > --- a/arch/arm/mach-s3c64xx/mach-hmt.c > +++ b/arch/arm/mach-s3c64xx/mach-hmt.c > @@ -207,7 +207,7 @@ static struct s3c2410_platform_nand hmt_nand_info = { > .ecc_mode = NAND_ECC_SOFT, > }; > > -static struct gpio_led hmt_leds[] = { > +static const struct gpio_led hmt_leds[] = { > { /* left function keys */ > .name = "left:blue", > .gpio = S3C64XX_GPO(12), > diff --git a/arch/arm/mach-s3c64xx/mach-smartq5.c b/arch/arm/mach-s3c64xx/mach-smartq5.c > index 0972b6c..5a7cd8f 100644 > --- a/arch/arm/mach-s3c64xx/mach-smartq5.c > +++ b/arch/arm/mach-s3c64xx/mach-smartq5.c > @@ -35,7 +35,7 @@ > #include "common.h" > #include "mach-smartq.h" > > -static struct gpio_led smartq5_leds[] = { > +static const struct gpio_led smartq5_leds[] = { > { > .name = "smartq5:green", > .active_low = 1, > diff --git a/arch/arm/mach-s3c64xx/mach-smartq7.c b/arch/arm/mach-s3c64xx/mach-smartq7.c > index 51ac1c6..9de9fc2 100644 > --- a/arch/arm/mach-s3c64xx/mach-smartq7.c > +++ b/arch/arm/mach-s3c64xx/mach-smartq7.c > @@ -35,7 +35,7 @@ > #include "common.h" > #include "mach-smartq.h" > > -static struct gpio_led smartq7_leds[] = { > +static const struct gpio_led smartq7_leds[] = { > { > .name = "smartq7:red", > .active_low = 1, > diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c > index 92ec8c3..be9d98f 100644 > --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c > +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c > @@ -497,7 +497,7 @@ static struct wm8350_platform_data __initdata smdk6410_wm8350_pdata = { > #endif > > #ifdef CONFIG_SMDK6410_WM1192_EV1 > -static struct gpio_led wm1192_pmic_leds[] = { > +static const struct gpio_led wm1192_pmic_leds[] = { > { > .name = "PMIC:red:power", > .gpio = GPIO_BOARD_START + 3, > -- > 2.7.4 >