Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751487AbdLZSLI convert rfc822-to-8bit (ORCPT ); Tue, 26 Dec 2017 13:11:08 -0500 Received: from 9pmail.ess.barracuda.com ([64.235.150.225]:46231 "EHLO 9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbdLZSKv (ORCPT ); Tue, 26 Dec 2017 13:10:51 -0500 X-Greylist: delayed 10703 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Dec 2017 13:10:48 EST From: Aleksandar Markovic To: Mathieu Malaterre CC: Ralf Baechle , Miodrag Dinic , Goran Ferenc , James Hogan , Douglas Leung , "linux-mips@linux-mips.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128` Thread-Topic: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128` Thread-Index: AQHTfjbDDkW3mp2YQEe0MOnepteVLqNVu/WCgAAwRaY= Date: Tue, 26 Dec 2017 18:10:30 +0000 Message-ID: References: <20171226104554.19612-1-malat@debian.org>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [82.117.201.26] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-BESS-ID: 1514311832-298554-11437-132503-1 X-BESS-VER: 2017.16-r1712230000 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.188373 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 36 > > Fix non-fatal warning: > > > > arch/mips/math-emu/dp_maddf.c:19:6: warning: no previous prototype for ?srl128? [-Wmissing-prototypes] > > void srl128(u64 *hptr, u64 *lptr, int count) > > > > Signed-off-by: Mathieu Malaterre > > --- > > arch/mips/math-emu/dp_maddf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c > > index 7ad79ed411f5..0e2278a47f43 100644 > > --- a/arch/mips/math-emu/dp_maddf.c > > +++ b/arch/mips/math-emu/dp_maddf.c > > @@ -16,7 +16,7 @@ > > > > > > /* 128 bits shift right logical with rounding. */ > > -void srl128(u64 *hptr, u64 *lptr, int count) > > +static void srl128(u64 *hptr, u64 *lptr, int count) > > { > > u64 low; > > > > -- > > 2.11.0 > > Acked-by: Aleksandar Markovic However, there is an already submitted patch: (the code change is identical) https://www.linux-mips.org/archives/linux-mips/2017-11/msg00044.html Status of that patch on patchwork is "Accepted". Regards, Aleksandar