Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbdLZSXa (ORCPT ); Tue, 26 Dec 2017 13:23:30 -0500 Received: from mail-ua0-f194.google.com ([209.85.217.194]:45315 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdLZSX3 (ORCPT ); Tue, 26 Dec 2017 13:23:29 -0500 X-Google-Smtp-Source: ACJfBotZgk5raRhPdwTARiqFKM5keG3XVj1FjUeAQTHsMn7a7O+UItVEmOWB2bHjV4JgGd7V9ohybzPE+3nEZnEQvnk= MIME-Version: 1.0 In-Reply-To: <20171226150549.GW21971@kernel.org> References: <20171226140913.16640-1-malat@debian.org> <20171226150549.GW21971@kernel.org> From: Mathieu Malaterre Date: Tue, 26 Dec 2017 19:23:08 +0100 X-Google-Sender-Auth: iGd4PNHo1zA__whjROC6Qnf1Uc0 Message-ID: Subject: Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBQINYRE023267 Content-Length: 1666 Lines: 51 Hi Arnaldo, On Tue, Dec 26, 2017 at 4:05 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: >> Fix non-fatal warning: >> >> kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] >> static void __always_inline >> ^~~~~~ > > Can you please provide more context? When did this become a problem? > What gcc version? > I tend to use W=1 before submitting a patch since not everything is being caught by ./scripts/checkpatch.pl. So this trivial patch was simply a way for me to remove some warning pollution I was seeing on my branch (not clear why this specific warning is considered an error in other section of the linux tree). This is a custom pmac32 branch, gcc version is: $ powerpc-linux-gnu-gcc --version powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 Feel free to drop it if this is too much noise. Thanks > - Arnaldo > >> Signed-off-by: Mathieu Malaterre >> --- >> kernel/events/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index 4df5b695bf0d..aa874d2b58b3 100644 >> --- a/kernel/events/core.c >> +++ b/kernel/events/core.c >> @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, >> data->phys_addr = perf_virt_to_phys(data->addr); >> } >> >> -static void __always_inline >> +static __always_inline void >> __perf_event_output(struct perf_event *event, >> struct perf_sample_data *data, >> struct pt_regs *regs, >> -- >> 2.11.0