Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdLZTAq (ORCPT ); Tue, 26 Dec 2017 14:00:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:34818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdLZTAo (ORCPT ); Tue, 26 Dec 2017 14:00:44 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B4252187C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: ACJfBouthIF+iBzCXBXdTzKEnnr3ftVSrR+tuYU+uoGzP3xx7XLUP8akRzJm84H1ZQ0arPZV8QkdnUAstVMHPoB2y5Y= MIME-Version: 1.0 In-Reply-To: <20171222122243.25735-2-icenowy@aosc.io> References: <20171222122243.25735-1-icenowy@aosc.io> <20171222122243.25735-2-icenowy@aosc.io> From: Rob Herring Date: Tue, 26 Dec 2017 13:00:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/11] dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3 To: Icenowy Zheng Cc: Maxime Ripard , Chen-Yu Tsai , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 18 On Fri, Dec 22, 2017 at 6:22 AM, Icenowy Zheng wrote: > The DE2 CCU is different on A83T and H3 -- the parent of the clocks on > A83T is PLL_DE but on H3 it's the DE module clock. This is not noticed > when I develop the DE2 CCU driver. > > Fix the binding by using different compatibles for A83T and H3, adding > notes for the PLL_DE usage on A83T, and change the binding example's > compatible from A83T to H3 (as it specifies the DE module clock). > > Fixes: ed74f8a8a679 ("dt-bindings: add binding for the Allwinner DE2 CCU") > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/clock/sun8i-de2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Please add acks when posting new versions. Rob