Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751205AbdLZUTm (ORCPT ); Tue, 26 Dec 2017 15:19:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:47174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdLZUTl (ORCPT ); Tue, 26 Dec 2017 15:19:41 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ABFD2188F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 26 Dec 2017 17:19:36 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Malaterre Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration Message-ID: <20171226201936.GX21971@kernel.org> References: <20171226140913.16640-1-malat@debian.org> <20171226150549.GW21971@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 57 Em Tue, Dec 26, 2017 at 07:23:08PM +0100, Mathieu Malaterre escreveu: > Hi Arnaldo, > > On Tue, Dec 26, 2017 at 4:05 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu: > >> Fix non-fatal warning: > >> kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > >> static void __always_inline > >> ^~~~~~ > > Can you please provide more context? When did this become a problem? > > What gcc version? > I tend to use W=1 before submitting a patch since not everything is > being caught by ./scripts/checkpatch.pl. So this trivial patch was > simply a way for me to remove some warning pollution I was seeing on > my branch (not clear why this specific warning is considered an error > in other section of the linux tree). This is a custom pmac32 branch, > gcc version is: > $ powerpc-linux-gnu-gcc --version > powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 > Feel free to drop it if this is too much noise. Nah, I just like to have enough info on the cset as to where is that the problem takes place, which you now have provided and I'll add to the cset, thanks! - Arnaldo > Thanks > > > - Arnaldo > > > >> Signed-off-by: Mathieu Malaterre > >> --- > >> kernel/events/core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/kernel/events/core.c b/kernel/events/core.c > >> index 4df5b695bf0d..aa874d2b58b3 100644 > >> --- a/kernel/events/core.c > >> +++ b/kernel/events/core.c > >> @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header, > >> data->phys_addr = perf_virt_to_phys(data->addr); > >> } > >> > >> -static void __always_inline > >> +static __always_inline void > >> __perf_event_output(struct perf_event *event, > >> struct perf_sample_data *data, > >> struct pt_regs *regs, > >> -- > >> 2.11.0