Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbdLZUyo (ORCPT ); Tue, 26 Dec 2017 15:54:44 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55383 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdLZUyn (ORCPT ); Tue, 26 Dec 2017 15:54:43 -0500 X-ME-Sender: Date: Tue, 26 Dec 2017 22:54:37 +0200 From: Ido Schimmel To: Willy Tarreau Cc: Wei Wang , Martin KaFai Lau , Eric Dumazet , "David S. Miller" , Sasha Levin , Greg Kroah-Hartman , Chris Rankin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, netdev@vger.kernel.org Subject: Re: BUG warnings in 4.14.9 Message-ID: <20171226205436.GA32546@splinter> References: <20171226185955.GA19208@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171226185955.GA19208@1wt.eu> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 19 On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote: > Guys, > > Chris reported the bug below and confirmed that reverting commit > 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to > have fixed the issue for him. This patch is a94b9367 in mainline. > > I personally have no opinion on the patch, just found it because it > was the only one touching this area between 4.14.8 and 4.14.9 :-) > > Should this be reverted or maybe fixed differently ? Maybe I'm missing something, but how come this patch even made its way into 4.14.y? It's part of a series to RCU-ify IPv6 FIB lookup that went into 4.15. Anyway, the mentioned bug was already fixed by commit 951f788a80ff ("ipv6: fix a BUG in rt6_get_pcpu_route()") when the code was still in net-next.