Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbdLZVA0 (ORCPT ); Tue, 26 Dec 2017 16:00:26 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:40524 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdLZVAY (ORCPT ); Tue, 26 Dec 2017 16:00:24 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume" From: Marcel Holtmann In-Reply-To: <20171220110008.11856-1-kai.heng.feng@canonical.com> Date: Tue, 26 Dec 2017 22:00:22 +0100 Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , stable , Leif Liddy , Matthias Kaehlcke , Brian Norris , Daniel Drake Content-Transfer-Encoding: 7bit Message-Id: References: <20171220110008.11856-1-kai.heng.feng@canonical.com> To: Kai-Heng Feng X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 35 Hi Kai-Heng, > This reverts commit fd865802c66bc451dc515ed89360f84376ce1a56. > > This commit causes a regression on some QCA ROME chips. The USB device > reset happens in btusb_open(), hence firmware loading gets interrupted. > > Furthermore, this commit stops working after commit > ("a0085f2510e8976614ad8f766b209448b385492f Bluetooth: btusb: driver to > enable the usb-wakeup feature"). Reset-resume quirk only gets enabled in > btusb_suspend() when it's not a wakeup source. > > If we really want to reset the USB device, we need to do it before > btusb_open(). Let's handle it in drivers/usb/core/quirks.c. > > Cc: stable@vger.kernel.org > Cc: Leif Liddy > Cc: Matthias Kaehlcke > Cc: Brian Norris > Cc: Daniel Drake > Signed-off-by: Kai-Heng Feng > > --- > > Daniel, Cc you because this also affects your original quirk patch for > Realtek btusb. > > drivers/bluetooth/btusb.c | 6 ------ > 1 file changed, 6 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel