Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbdLZVBu convert rfc822-to-8bit (ORCPT ); Tue, 26 Dec 2017 16:01:50 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:52991 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdLZVBs (ORCPT ); Tue, 26 Dec 2017 16:01:48 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth From: Marcel Holtmann In-Reply-To: <20171220110008.11856-2-kai.heng.feng@canonical.com> Date: Tue, 26 Dec 2017 22:01:46 +0100 Cc: linux-usb@vger.kernel.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , stable , Leif Liddy , Matthias Kaehlcke , Brian Norris , Daniel Drake Content-Transfer-Encoding: 8BIT Message-Id: References: <20171220110008.11856-1-kai.heng.feng@canonical.com> <20171220110008.11856-2-kai.heng.feng@canonical.com> To: Kai-Heng Feng , Greg Kroah-Hartman X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 40 Hi Greg, > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This > makes the device resets during btusb_open(), firmware loading gets > interrupted as a result. > > We still want to reset the device to solve the original issue, but we > should do it before btusb_open(). > > Hence, add reset-resume quirk in usb core intead of btusb. > > Cc: stable@vger.kernel.org > Cc: Leif Liddy > Cc: Matthias Kaehlcke > Cc: Brian Norris > Cc: Daniel Drake > Signed-off-by: Kai-Heng Feng > > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index a10b346b9777..96951104c45b 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = { > { USB_DEVICE(0x0b05, 0x17e0), .driver_info = > USB_QUIRK_IGNORE_REMOTE_WAKEUP }, > > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */ > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME }, > + can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it? Regards Marcel