Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbdLZV1t (ORCPT ); Tue, 26 Dec 2017 16:27:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdLZV1s (ORCPT ); Tue, 26 Dec 2017 16:27:48 -0500 From: Josh Poimboeuf To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Lukas Bulwahn , Jiri Slaby , Nick Desaulniers Subject: [PATCH] objtool: Fix clang enum conversion warning Date: Tue, 26 Dec 2017 15:27:20 -0600 Message-Id: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 26 Dec 2017 21:27:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 36 From: Lukas Bulwahn Fix the following clang enum conversion warning: arch/x86/decode.c:141:20: error: implicit conversion from enumeration type 'enum op_src_type' to different enumeration type 'enum op_dest_type' [-Werror,-Wenum-conversion] op->dest.type = OP_SRC_REG; ~ ^~~~~~~~~~ It just happened to work before because OP_SRC_REG and OP_DEST_REG have the same value. Fixes: baa41469a7b9 ("objtool: Implement stack validation 2.0") Signed-off-by: Lukas Bulwahn Signed-off-by: Josh Poimboeuf --- tools/objtool/arch/x86/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c index 8acfc47af70e..540a209b78ab 100644 --- a/tools/objtool/arch/x86/decode.c +++ b/tools/objtool/arch/x86/decode.c @@ -138,7 +138,7 @@ int arch_decode_instruction(struct elf *elf, struct section *sec, *type = INSN_STACK; op->src.type = OP_SRC_ADD; op->src.reg = op_to_cfi_reg[modrm_reg][rex_r]; - op->dest.type = OP_SRC_REG; + op->dest.type = OP_DEST_REG; op->dest.reg = CFI_SP; } break; -- 2.13.6