Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751603AbdLZWX2 (ORCPT ); Tue, 26 Dec 2017 17:23:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58072 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdLZWX1 (ORCPT ); Tue, 26 Dec 2017 17:23:27 -0500 Date: Tue, 26 Dec 2017 17:23:25 -0500 (EST) Message-Id: <20171226.172325.1433338035798239001.davem@davemloft.net> To: privat@egil-hjelmeland.no Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: dsa: lan9303: lan9303_csr_reg_wait cleanups From: David Miller In-Reply-To: <20171221173435.13100-1-privat@egil-hjelmeland.no> References: <20171221173435.13100-1-privat@egil-hjelmeland.no> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Dec 2017 14:23:26 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 425 Lines: 12 From: Egil Hjelmeland Date: Thu, 21 Dec 2017 18:34:35 +0100 > Non-functional cleanups in lan9303_csr_reg_wait(): > - Change type of param 'mask' from int to u32. > - Remove param 'value' (will probably never be used) > - Reduced retries from 1000 to 25, consistent with lan9303_read_wait. > - Removed comments > > Signed-off-by: Egil Hjelmeland Applied, thanks.