Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbdL0BKZ (ORCPT ); Tue, 26 Dec 2017 20:10:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55500 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdL0BKX (ORCPT ); Tue, 26 Dec 2017 20:10:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A4CAE602B9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 26 Dec 2017 17:10:21 -0800 From: Stephen Boyd To: sean.wang@mediatek.com Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, jdelvare@suse.de, jamesjj.liao@mediatek.com, weiyi.lu@mediatek.com, arnd@arndb.de, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c Message-ID: <20171227011021.GQ7997@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 29 On 12/25, sean.wang@mediatek.com wrote: > From: Sean Wang > > In fact, the clk-mtk.h header is indeed not needed for reset.c and thus > it's safe and good change to remove it from the file. > > Signed-off-by: Sean Wang > Reviewed-by: Jean Delvare > Cc: Jean Delvare > --- > drivers/clk/mediatek/reset.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c > index d3551d5..70ebb2e 100644 > --- a/drivers/clk/mediatek/reset.c > +++ b/drivers/clk/mediatek/reset.c > @@ -19,8 +19,6 @@ > #include > #include > > -#include "clk-mtk.h" > - drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project