Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbdL0BTj (ORCPT ); Tue, 26 Dec 2017 20:19:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59456 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdL0BTh (ORCPT ); Tue, 26 Dec 2017 20:19:37 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9118E60398 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 26 Dec 2017 17:19:36 -0800 From: Stephen Boyd To: sean.wang@mediatek.com Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, jdelvare@suse.de, jamesjj.liao@mediatek.com, weiyi.lu@mediatek.com, kevin-cw.chen@mediatek.com, shunli.wang@mediatek.com, chen.zhong@mediatek.com, arnd@arndb.de, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built Message-ID: <20171227011936.GT7997@codeaurora.org> References: <5a6347a5196a5eba85dce9ac7c3b9392b832f1f8.1514259933.git.sean.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a6347a5196a5eba85dce9ac7c3b9392b832f1f8.1514259933.git.sean.wang@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 24 On 12/26, sean.wang@mediatek.com wrote: > From: Sean Wang > > commit 74cb0d6dde8 ("clk: mediatek: fixup test-building of MediaTek clock > drivers") can let the build system looking into the directory where the > clock drivers resides and then allow test-building the drivers. > > But the change also gives rise to certain incorrect behavior which is > reset.c being built even not depending on either COMPILE_TEST or > ARCH_MEDIATEK alternative dependency. To get rid of reset.c being built > unexpectedly on the other platforms, it would be a good change that the > file should be built depending on its own specific configuration rather > than just on generic RESET_CONTROLLER one. > > Signed-off-by: Sean Wang > Cc: Jean Delvare I've typically seen vendor Kconfigs select the RESET_CONTROLLER framework if the vendor Kconfig is enabled. Any reason that same method isn't followed here? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project