Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766AbdL0CH4 (ORCPT ); Tue, 26 Dec 2017 21:07:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:38504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdL0CHz (ORCPT ); Tue, 26 Dec 2017 21:07:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B0CF218C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Wed, 27 Dec 2017 10:07:50 +0800 From: Shawn Guo To: Dong Aisheng Cc: Peng Fan , "A.s. Dong" , "linux-kernel@vger.kernel.org" , Russell King , Fabio Estevam , Sascha Hauer , "van.freenix@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume Message-ID: <20171227020749.GU23070@X250> References: <20171210120718.15197-1-peng.fan@nxp.com> <20171226091230.GP23070@X250> <20171226100344.GA11724@b29396-OptiPlex-7040> <20171226102038.GB11724@b29396-OptiPlex-7040> <20171226103629.GC11724@b29396-OptiPlex-7040> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171226103629.GC11724@b29396-OptiPlex-7040> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 30 On Tue, Dec 26, 2017 at 06:36:29PM +0800, Dong Aisheng wrote: > > > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach- > > > > imx/cpuidle-imx6sx.c > > > > index c5a5c3a..edce5bd 100644 > > > > --- a/arch/arm/mach-imx/cpuidle-imx6sx.c > > > > +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c > > > > @@ -26,7 +26,7 @@ static int imx6sx_idle_finish(unsigned long val) > > > > * to adding conditional code for L2 cache type, > > > > * just call flush_cache_all() is fine. > > > > */ > > > > - flush_cache_all(); > > > > +// flush_cache_all(); > > > > > > I think flush_cache_all is still needed, to flush L1 data, right? > > > > > > > I thought it will be done in generic cpu_suspend. > > See: __cpu_suspend_save() > > > > So we still need it? > > > > Shawn, > > Do you have comments about it? It seems that there are comments about this flush_cache_all() call right above it. To be safe, I would suggest to keep it as it is. Shawn