Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbdL0CcJ (ORCPT ); Tue, 26 Dec 2017 21:32:09 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:5233 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdL0CcH (ORCPT ); Tue, 26 Dec 2017 21:32:07 -0500 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 26 Dec 2017 18:32:07 -0800 Subject: Re: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev_driver static To: Xiongwei Song , CC: , References: <20171221231226.15505-1-sxwjean@gmail.com> X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: Date: Wed, 27 Dec 2017 08:01:56 +0530 MIME-Version: 1.0 In-Reply-To: <20171221231226.15505-1-sxwjean@gmail.com> X-Originating-IP: [10.24.70.247] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 47 On 12/22/2017 4:42 AM, Xiongwei Song wrote: > The functions vfio_mdev_probe, vfio_mdev_remove and the structure > vfio_mdev_driver are only used in this file, so make them static. > > Clean up sparse warnings: > drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype > for 'vfio_mdev_probe' [-Wmissing-prototypes] > drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype > for 'vfio_mdev_remove' [-Wmissing-prototypes] > > Signed-off-by: Xiongwei Song > --- > drivers/vfio/mdev/vfio_mdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index fa848a701b8b..d230620fe02d 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -111,19 +111,19 @@ static const struct vfio_device_ops vfio_mdev_dev_ops = { > .mmap = vfio_mdev_mmap, > }; > > -int vfio_mdev_probe(struct device *dev) > +static int vfio_mdev_probe(struct device *dev) > { > struct mdev_device *mdev = to_mdev_device(dev); > > return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev); > } > > -void vfio_mdev_remove(struct device *dev) > +static void vfio_mdev_remove(struct device *dev) > { > vfio_del_group_dev(dev); > } > > -struct mdev_driver vfio_mdev_driver = { > +static struct mdev_driver vfio_mdev_driver = { > .name = "vfio_mdev", > .probe = vfio_mdev_probe, > .remove = vfio_mdev_remove, > Reviewed by: Kirti Wankhede