Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbdL0DdI (ORCPT ); Tue, 26 Dec 2017 22:33:08 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:14781 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751163AbdL0DdH (ORCPT ); Tue, 26 Dec 2017 22:33:07 -0500 X-UUID: a2498605d717474c93366dea10a45138-20171227 Message-ID: <1514345580.30687.27.camel@mtkswgap22> Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c From: Sean Wang To: Stephen Boyd CC: , , , , , , , , Date: Wed, 27 Dec 2017 11:33:00 +0800 In-Reply-To: <20171227011021.GQ7997@codeaurora.org> References: <20171227011021.GQ7997@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 47 On Tue, 2017-12-26 at 17:10 -0800, Stephen Boyd wrote: > On 12/25, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > In fact, the clk-mtk.h header is indeed not needed for reset.c and thus > > it's safe and good change to remove it from the file. > > > > Signed-off-by: Sean Wang > > Reviewed-by: Jean Delvare > > Cc: Jean Delvare > > --- > > drivers/clk/mediatek/reset.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c > > index d3551d5..70ebb2e 100644 > > --- a/drivers/clk/mediatek/reset.c > > +++ b/drivers/clk/mediatek/reset.c > > @@ -19,8 +19,6 @@ > > #include > > #include > > > > -#include "clk-mtk.h" > > - > > drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static? > It cannot be static since the function would be referenced in other files under the same folder One point I felt confused which is I didn't see the warning complains when I did these build test, even I also added -Werror and -Wall to build all files under driver/clk/mediatek. My toolchain is based on gcc version 5.2.0 (GCC). If the warning still is, the include "clk-mtk.h" should be good to stay there because the declaration it needs is in the clk-mtk.h