Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdL0E1Q (ORCPT ); Tue, 26 Dec 2017 23:27:16 -0500 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:28344 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbdL0E1N (ORCPT ); Tue, 26 Dec 2017 23:27:13 -0500 From: alexander.levin@verizon.com X-Host: mariner.tdc.vzwcorp.com To: Ido Schimmel CC: Willy Tarreau , Wei Wang , Martin KaFai Lau , Eric Dumazet , "David S. Miller" , Greg Kroah-Hartman , "Chris Rankin" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: BUG warnings in 4.14.9 Thread-Topic: BUG warnings in 4.14.9 Thread-Index: AQHTfsqoCRVQ28sYiUCsHo4/7MXtMA== Date: Wed, 27 Dec 2017 04:25:00 +0000 Message-ID: <20171227042459.cm7hgti47rkmwf3d@sasha-lappy> References: <20171226185955.GA19208@1wt.eu> <20171226205436.GA32546@splinter> In-Reply-To: <20171226205436.GA32546@splinter> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: <7ABE9CE6C3EC3143B062C767A7637775@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBR4RLmn018851 Content-Length: 942 Lines: 27 On Tue, Dec 26, 2017 at 10:54:37PM +0200, Ido Schimmel wrote: >On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote: >> Guys, >> >> Chris reported the bug below and confirmed that reverting commit >> 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to >> have fixed the issue for him. This patch is a94b9367 in mainline. >> >> I personally have no opinion on the patch, just found it because it >> was the only one touching this area between 4.14.8 and 4.14.9 :-) >> >> Should this be reverted or maybe fixed differently ? > >Maybe I'm missing something, but how come this patch even made its way >into 4.14.y? It's part of a series to RCU-ify IPv6 FIB lookup that went >into 4.15. > >Anyway, the mentioned bug was already fixed by commit 951f788a80ff >("ipv6: fix a BUG in rt6_get_pcpu_route()") when the code was still in >net-next. Uh, you're right. Greg, please just revert 9704f81. Thanks! -- Thanks, Sasha