Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751151AbdL0ITI (ORCPT ); Wed, 27 Dec 2017 03:19:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:51338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdL0ITH (ORCPT ); Wed, 27 Dec 2017 03:19:07 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E81C62190E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: ACJfBothLtWIHWBSKGLw7MaiUvs81Frx5kh16U2E22a414J6agzg9fxPSTvP9tyVqptFEISo6zA9AttuUcc3gbF27w4= MIME-Version: 1.0 In-Reply-To: References: From: Krzysztof Kozlowski Date: Wed, 27 Dec 2017 09:19:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led To: Arvind Yadav Cc: nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, kaloz@openwrt.org, khalasa@piap.pl, aaro.koskinen@iki.fi, tony@atomide.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, daniel@zonque.org, haojian.zhuang@gmail.com, marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk, kgene@kernel.org, ralf@linux-mips.org, ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 28 On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav wrote: > gpio_led are not supposed to change at runtime. > struct gpio_led_platform_data working with const gpio_led > provided by . So mark the non-const structs > as const. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > The GPIO LED driver can be built as a module, it can > be loaded after the init sections have gone away. > So removed '__initconst'. > changes in v3: > Description was missing. > > arch/arm/mach-s3c24xx/mach-h1940.c | 2 +- > arch/arm/mach-s3c24xx/mach-rx1950.c | 2 +- > arch/arm/mach-s3c64xx/mach-hmt.c | 2 +- > arch/arm/mach-s3c64xx/mach-smartq5.c | 2 +- > arch/arm/mach-s3c64xx/mach-smartq7.c | 2 +- > arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) There were few build errors reported by kbuild for your patches. Are you sure that you compiled every file you touch? Best regards, Krzysztof