Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261AbdL0I1F (ORCPT ); Wed, 27 Dec 2017 03:27:05 -0500 Received: from mail-ua0-f194.google.com ([209.85.217.194]:46698 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdL0I1D (ORCPT ); Wed, 27 Dec 2017 03:27:03 -0500 X-Google-Smtp-Source: ACJfBotIL5xF3h94lHUOZtA4JSY0gbQInvpcfhkFXOe2akb06sj2xMwFH5hPiksmZl2wHk2G9aI5p/jXaFxp/KoI4Z0= MIME-Version: 1.0 In-Reply-To: References: <20171226104554.19612-1-malat@debian.org> From: Mathieu Malaterre Date: Wed, 27 Dec 2017 09:26:42 +0100 X-Google-Sender-Auth: fkbN9Xdu803L0D3e1knkT9BNSn4 Message-ID: Subject: Re: [PATCH 1/2] MIPS: math-emu: Do not export function `srl128` To: Aleksandar Markovic Cc: Ralf Baechle , Miodrag Dinic , Goran Ferenc , James Hogan , Douglas Leung , "linux-mips@linux-mips.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBR8R9rm008839 Content-Length: 1246 Lines: 39 On Tue, Dec 26, 2017 at 7:10 PM, Aleksandar Markovic wrote: >> > Fix non-fatal warning: >> > >> > arch/mips/math-emu/dp_maddf.c:19:6: warning: no previous prototype for ‘srl128’ [-Wmissing-prototypes] >> > void srl128(u64 *hptr, u64 *lptr, int count) >> > >> > Signed-off-by: Mathieu Malaterre >> > --- >> > arch/mips/math-emu/dp_maddf.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c >> > index 7ad79ed411f5..0e2278a47f43 100644 >> > --- a/arch/mips/math-emu/dp_maddf.c >> > +++ b/arch/mips/math-emu/dp_maddf.c >> > @@ -16,7 +16,7 @@ >> > >> > >> > /* 128 bits shift right logical with rounding. */ >> > -void srl128(u64 *hptr, u64 *lptr, int count) >> > +static void srl128(u64 *hptr, u64 *lptr, int count) >> > { >> > u64 low; >> > >> > -- >> > 2.11.0 >> >> Acked-by: Aleksandar Markovic > > However, there is an already submitted patch: (the code change is identical) > > https://www.linux-mips.org/archives/linux-mips/2017-11/msg00044.html > > Status of that patch on patchwork is "Accepted". Sorry did not realized you sent it already. Thanks