Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdL0JAP (ORCPT ); Wed, 27 Dec 2017 04:00:15 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:45674 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdL0JAN (ORCPT ); Wed, 27 Dec 2017 04:00:13 -0500 X-IronPort-AV: E=Sophos;i="5.45,464,1508774400"; d="scan'208";a="67086138" From: Avri Altman To: Greg Kroah-Hartman , Jaegeuk Kim CC: "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Jaegeuk Kim , Alex Lemberg , Stanislav Nijnikov Subject: RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info Thread-Topic: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info Thread-Index: AQHTejGpMGP3jDRAGUeapBc61uTOzaNW6zuQ Date: Wed, 27 Dec 2017 09:00:10 +0000 Message-ID: References: <20171220191631.50329-1-jaegeuk@kernel.org> <20171220191631.50329-2-jaegeuk@kernel.org> <20171220221325.GA56741@jaegeuk-macbookpro.roam.corp.google.com> <20171221075935.GB9645@kroah.com> In-Reply-To: <20171221075935.GB9645@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR0401MB1236;20:EtGnyljwMS+aGqvI+uqpLIliKPDeUly9d/IdmoJNkupCbHbyxbEqD9wCkYzOjyqm7qgHgtB1wHKBtk4F6t31IUvVtAh2ShOBvCRbSvXfaRLomu1f1stKTPqBUvBEkaL0TUWqx0I4W/EjonHThJJlpH4pbPgCX4HYo5A3CtALNoo= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 6f599cfb-c514-4644-a624-08d54d083bfe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060);SRVR:BN3PR0401MB1236; x-ms-traffictypediagnostic: BN3PR0401MB1236: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(211936372134217)(153496737603132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231023)(920507027)(944501075)(3002001)(10201501046)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:BN3PR0401MB1236;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN3PR0401MB1236; x-forefront-prvs: 0534947130 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(346002)(39380400002)(376002)(39860400002)(51444003)(13464003)(24454002)(189003)(199004)(99286004)(2906002)(81166006)(14454004)(74316002)(34040400001)(6246003)(3280700002)(6436002)(7736002)(33656002)(316002)(76176011)(7696005)(5660300001)(305945005)(25786009)(72206003)(8676002)(4326008)(54906003)(110136005)(81156014)(59450400001)(3660700001)(6506007)(53546011)(106356001)(93886005)(68736007)(478600001)(3846002)(229853002)(105586002)(6116002)(53936002)(86362001)(102836004)(9686003)(2900100001)(8936002)(66066001)(55016002)(77096006)(2950100002)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0401MB1236;H:DM5PR04MB1085.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: d/8RSd7ytvRUNxvqjD2IUW6v0eueRXirNbKnEDiJQELv5EFiIoHhLkUVQAgC7GWt2savpURVZuzzScLPrKsmcA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f599cfb-c514-4644-a624-08d54d083bfe X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2017 09:00:10.2539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0401MB1236 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBR90L8J016921 Content-Length: 1155 Lines: 27 > -----Original Message----- > From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- > owner@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > Sent: Thursday, December 21, 2017 10:00 AM > To: Jaegeuk Kim > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; Jaegeuk Kim > > Subject: Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS > health info > > On Wed, Dec 20, 2017 at 02:13:25PM -0800, Jaegeuk Kim wrote: > > This patch adds a new sysfs group, namely health, via: > > > > /sys/devices/soc/X.ufshc/health/ As device health is just one piece of information out of the device management, I think that you should address this in a more comprehensive way, And set hooks for much more device info: Allow access to device descriptors, attributes and flags. The attributes and flags should be placed in separate subfolders The LUN specific descriptors and attributes should be placed in a luns subfolder, and then per descriptor / attribute type You might also would like to consider differentiating read and write - to control those type of accesses as well. Cheers, Avri