Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbdL0Jnq (ORCPT ); Wed, 27 Dec 2017 04:43:46 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:50750 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750950AbdL0Jnm (ORCPT ); Wed, 27 Dec 2017 04:43:42 -0500 X-UUID: 6f500134e29c49af814d16d6493267d9-20171227 Message-ID: <1514367817.30687.59.camel@mtkswgap22> Subject: Re: [PATCH] clk: mediatek: adjust dependency of reset.c to avoid unexpectedly being built From: Sean Wang To: Stephen Boyd CC: , , , , , , , , , , , Date: Wed, 27 Dec 2017 17:43:37 +0800 In-Reply-To: <20171227011936.GT7997@codeaurora.org> References: <5a6347a5196a5eba85dce9ac7c3b9392b832f1f8.1514259933.git.sean.wang@mediatek.com> <20171227011936.GT7997@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1918 Lines: 49 On Tue, 2017-12-26 at 17:19 -0800, Stephen Boyd wrote: > On 12/26, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > commit 74cb0d6dde8 ("clk: mediatek: fixup test-building of MediaTek clock > > drivers") can let the build system looking into the directory where the > > clock drivers resides and then allow test-building the drivers. > > > > But the change also gives rise to certain incorrect behavior which is > > reset.c being built even not depending on either COMPILE_TEST or > > ARCH_MEDIATEK alternative dependency. To get rid of reset.c being built > > unexpectedly on the other platforms, it would be a good change that the > > file should be built depending on its own specific configuration rather > > than just on generic RESET_CONTROLLER one. > > > > Signed-off-by: Sean Wang > > Cc: Jean Delvare > > I've typically seen vendor Kconfigs select the RESET_CONTROLLER > framework if the vendor Kconfig is enabled. Any reason that same > method isn't followed here? > I just thought explicit dependency added in Kconfig seems a little good no matter how the vendor Kconfig forces to select. But, I believe reset controller is always present on every mediatek SoC, at least it can be found on infracfg and pericfg subsystem, which is really fundamental hardware block. So, it's still quite reasonable to add "RESET_CONTROLLER" to vendor Kconfig. Once we did it in vendor Kconfig, the Kconfig maybe could become something like that. config RESET_MEDIATEK bool "MediaTek Reset Driver" depends on ARCH_MEDIATEK || (RESET_CONTROLLER && COMPILE_TEST) help This enables the reset controller driver used on MediaTek SoCs. where COMPILE_TEST still has to depend on RESET_CONTROLLER to avoid any compiling error. I'll make the next version based on above and relevant vendor Kconfig changes Sean