Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbdL0KE4 (ORCPT ); Wed, 27 Dec 2017 05:04:56 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:53961 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbdL0KEy (ORCPT ); Wed, 27 Dec 2017 05:04:54 -0500 Cc: Maya Erez , Kalle Valo , Arnd Bergmann , Lazar Alexei , Dedy Lansky , Hamad Kadmany , Lior David , Gidon Studinski , , , , X-IronPort-AV: E=McAfee;i="5900,7806,8756"; a="17412781" X-MGA-submission: =?us-ascii?q?MDE/DEy+EZ7dqmjZC2vvOqoRbviu3linDnzbP7?= =?us-ascii?q?9dW+cSqAK4ol2LJO+yyHkC+wMsbIw3z63iqkbPbeMtvt1XKAT7OTZXTf?= =?us-ascii?q?rC15r18/lnSvTZBVQzER6DF4fCijQj8tKtfocMkOzDqf6AdqgDEFf1Uf?= =?us-ascii?q?yb?= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wil6210: fix build warnings without CONFIG_PM From: Kalle Valo In-Reply-To: <20171218134604.3087909-1-arnd@arndb.de> References: <20171218134604.3087909-1-arnd@arndb.de> To: Arnd Bergmann User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-ID: <798460c2d6ed47dcb85c9540829a5ef8@euamsexm01a.eu.qualcomm.com> Date: Wed, 27 Dec 2017 11:04:43 +0100 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01G.na.qualcomm.com (10.85.0.33) To euamsexm01a.eu.qualcomm.com (10.251.127.40) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 24 Arnd Bergmann wrote: > The #ifdef checks are hard to get right, in this case some functions > should have been left inside a CONFIG_PM_SLEEP check as seen by this > message: > > drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function] > drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_suspend' defined but not used [-Werror=unused-function] > > Using an __maybe_unused is easier here, so I'm replacing all the > other #ifdef in this file as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 203dab8395d9 wil6210: fix build warnings without CONFIG_PM -- https://patchwork.kernel.org/patch/10119565/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches