Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbdL0LDV (ORCPT ); Wed, 27 Dec 2017 06:03:21 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:39745 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbdL0LDT (ORCPT ); Wed, 27 Dec 2017 06:03:19 -0500 X-Google-Smtp-Source: ACJfBosziMBv01PNnYGb2YtanBfcn1JI1oqtXpzkuWW/JPFaabHfZj1uGr2KQ5oBYkeeywDxiZLwFg== Subject: Re: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led To: Krzysztof Kozlowski References: Cc: nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, kaloz@openwrt.org, khalasa@piap.pl, aaro.koskinen@iki.fi, tony@atomide.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, daniel@zonque.org, haojian.zhuang@gmail.com, marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk, kgene@kernel.org, ralf@linux-mips.org, ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: arvindY Message-ID: <5A437DED.3030703@gmail.com> Date: Wed, 27 Dec 2017 16:33:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 35 Hi, On Wednesday 27 December 2017 01:49 PM, Krzysztof Kozlowski wrote: > On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav wrote: >> gpio_led are not supposed to change at runtime. >> struct gpio_led_platform_data working with const gpio_led >> provided by . So mark the non-const structs >> as const. >> >> Signed-off-by: Arvind Yadav >> --- >> changes in v2: >> The GPIO LED driver can be built as a module, it can >> be loaded after the init sections have gone away. >> So removed '__initconst'. >> changes in v3: >> Description was missing. >> >> arch/arm/mach-s3c24xx/mach-h1940.c | 2 +- >> arch/arm/mach-s3c24xx/mach-rx1950.c | 2 +- >> arch/arm/mach-s3c64xx/mach-hmt.c | 2 +- >> arch/arm/mach-s3c64xx/mach-smartq5.c | 2 +- >> arch/arm/mach-s3c64xx/mach-smartq7.c | 2 +- >> arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +- >> 6 files changed, 6 insertions(+), 6 deletions(-) > There were few build errors reported by kbuild for your patches. Are > you sure that you compiled every file you touch? > > Best regards, > Krzysztof Yes, I got few build error which I have fixed it. and send updated patch. Now I have done cross checking. It's not having any build failure. Regards arvind