Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbdL0MP4 (ORCPT ); Wed, 27 Dec 2017 07:15:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:55697 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdL0MPz (ORCPT ); Wed, 27 Dec 2017 07:15:55 -0500 Date: Wed, 27 Dec 2017 13:15:50 +0100 From: Jean Delvare To: Sean Wang Cc: Stephen Boyd , , , , , , , , Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c Message-ID: <20171227131550.2c65c6ff@endymion> In-Reply-To: <1514345580.30687.27.camel@mtkswgap22> References: <20171227011021.GQ7997@codeaurora.org> <1514345580.30687.27.camel@mtkswgap22> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 28 Hi Sean, Stephen, On Wed, 27 Dec 2017 11:33:00 +0800, Sean Wang wrote: > On Tue, 2017-12-26 at 17:10 -0800, Stephen Boyd wrote: > > drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static? > > It cannot be static since the function would be referenced in other > files under the same folder > > > One point I felt confused which is I didn't see the warning complains > when I did these build test, even I also added -Werror and -Wall to > build all files under driver/clk/mediatek. My toolchain is based on gcc > version 5.2.0 (GCC). I tested and I get the warning here (gcc 4.8.5 on SUSE) but only after setting CONFIG_RESET_CONTROLLER=y. Without it, drivers/clk/mediatek/reset.o is never built, so no warning can be generated. > If the warning still is, the include "clk-mtk.h" should be good to stay > there because the declaration it needs is in the clk-mtk.h Agreed. -- Jean Delvare SUSE L3 Support