Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbdL0M5a (ORCPT ); Wed, 27 Dec 2017 07:57:30 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36900 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdL0M52 (ORCPT ); Wed, 27 Dec 2017 07:57:28 -0500 Date: Wed, 27 Dec 2017 13:52:04 +0100 From: Greg Kroah-Hartman To: Marcel Holtmann Cc: Kai-Heng Feng , linux-usb@vger.kernel.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , stable , Leif Liddy , Matthias Kaehlcke , Brian Norris , Daniel Drake Subject: Re: [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth Message-ID: <20171227125204.GE3373@kroah.com> References: <20171220110008.11856-1-kai.heng.feng@canonical.com> <20171220110008.11856-2-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 42 On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote: > Hi Greg, > > > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix > > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This > > makes the device resets during btusb_open(), firmware loading gets > > interrupted as a result. > > > > We still want to reset the device to solve the original issue, but we > > should do it before btusb_open(). > > > > Hence, add reset-resume quirk in usb core intead of btusb. > > > > Cc: stable@vger.kernel.org > > Cc: Leif Liddy > > Cc: Matthias Kaehlcke > > Cc: Brian Norris > > Cc: Daniel Drake > > Signed-off-by: Kai-Heng Feng > > > > --- > > drivers/usb/core/quirks.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > > index a10b346b9777..96951104c45b 100644 > > --- a/drivers/usb/core/quirks.c > > +++ b/drivers/usb/core/quirks.c > > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = { > > { USB_DEVICE(0x0b05, 0x17e0), .driver_info = > > USB_QUIRK_IGNORE_REMOTE_WAKEUP }, > > > > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */ > > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME }, > > + > > can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it? It's not in my queue at all, so I didn't even have the chance to take it :) Acked-by: Greg Kroah-Hartman