Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdL0Oqr (ORCPT ); Wed, 27 Dec 2017 09:46:47 -0500 Received: from mail-he1eur01on0113.outbound.protection.outlook.com ([104.47.0.113]:49232 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751000AbdL0Oqq (ORCPT ); Wed, 27 Dec 2017 09:46:46 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=romain.porte@nokia.com; Subject: Re: [PATCH v2] mtd: spi-nor: Added ISSI is25lp080d support To: cyrille.pitchen@wedev4u.fr Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alexander.sverdlin@nokia.com, pascal.fabreges@nokia.com References: <20171219134325.3315-1-romain.porte@nokia.com> <20171227135809.2407-1-romain.porte@nokia.com> From: Romain Porte Message-ID: Date: Wed, 27 Dec 2017 15:46:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171227135809.2407-1-romain.porte@nokia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [135.245.212.4] X-ClientProxiedBy: HE1PR0501CA0016.eurprd05.prod.outlook.com (2603:10a6:3:1a::26) To DB6PR0701MB2885.eurprd07.prod.outlook.com (2603:10a6:4:71::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1f39b068-957f-41a6-4c4d-08d54d38a539 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307);SRVR:DB6PR0701MB2885; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2885;3:NAOUjeVaWWtpHHOCdqHaYhA1zWEGXj7/0kQr+ItMnkMlEbJbFFavHegLu58+kEW5vfFmZiUylDdmHjnZjOSISideoIHDQ1pFxKjc5TbUXBkGALUfD/RYZ/m413osF3hb8Lp9aImJBAEVURertJb51rD5JX/P/zSNDDa4eyyXq9nA8q/yvyWTfDatXzHY5vvZGEaUSMFmh4NDVau1oH6I2NsHuNcU/z+HahBaWsMDLP1UgQ1iAOsSt2OlHI7PaPMf;25:Nkcbp/tY/Obildw4zZxiI0j/ewrfO8oQGojfaIwwmIrDJUp2Gzf0gM+V1v25o+FI4by7XoCKC1YXkoi+wBh6MWZXhEGlUumKrDFkQOQ2XnKK/7OJOrwggYtDNaEgjwZ6t1Nb4xnwoV/vw1F/VK8msHkfCqAm27H7N/6OTV+xjJXiTmHvGlXgV6SEteBreMytrY0Gt6dkBW+EjHPipNia6Hgk5+Z65dkHn1eEYp4Ud/fNUEHz/GRmIq1goHk4sHf46mCMQPqMAX3IZM83Wf8Oso3U6eyWx8EnG7WnGAXl36qXJi/PEprjAPneD/+bXIEheyogX9mo/rX0yMsyMwYkZw==;31:WO9BrolmmSRmwqSk782ZoIbwvGtoGbaM69vuWznKlgPwFepfcCU2nb52aR5jEZoWYowgSDdI9Z2XosMlOhpfiXv+HMOmlPQBk8vqYQjrE7DQ2dmW+J+D/9djYKQWAZYtSS+zyWfZOl7Hq3B/kcZ7hIfyhP5lrqLd0cavb0btrf845+VpgnQ24ThBSkJDEeJ0VIcvuNGPOIkoib9mjzxpAcVZQywVqrPf2LZlF1ojojU= X-MS-TrafficTypeDiagnostic: DB6PR0701MB2885: X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2885;20:2ry+6pHdYTJRlNDy33YX5XeOuIRTga54z7biCu5/3uy6d6eZqM9xC6RPAGsaaeJ2jBiciaTy9VkNpEI40Nk5rznKjF1frWf7Tph2UzVqgyAmOrHGrgH5/zu8mHJmsBXDFHZEJgIyR72c9EAYj7MSCtnQkyDKnnZ1XUl/w3KLNRZeGCuOQgAUm0bXr79wxEH0di8GYaABhuqcKzkvuBlyLSwP+aCGSVfBiO+9Nase75gsVth30y+LLVG1eW4DSvDxT2Q5z++ulES+jQ5Kfx3Qb8ibm7hPMPG/vuBiENw0wj9fALdOUf6vHJDr6nPJRJx744L13VMdGp2B9Tivlma5NzHE8XmvXCk1HEKb9Doc+lhH/rsmct878FEKvqNdWI+Y8kwZiuCd+4cHDiOoSUfsb2ZDD8ZoMIgOWSZsqNUsX84jziLEknwcarteiNlw3nXe0D+ez2VyeJJQiJLdDFU838D/Vuk3AEtgDin9sBL2/Ft2mXg+weDAn09l92eXbX0F;4:v4Cb0Appugoen5RDDwIc0Gi1dTMEvUVYlbr4a1daSTBf4swm3r8LITSLJJr0efHGTuiZxmNWKOiCM0byUBsx/Wm82wl1SRfvE1GpnOybyA9Gd6S+hcMERUwtDonBqtRu7KHxdIhzKH0pbr5O13itnR4p/lqxe7Go5tBo2ymVfrMKH2wjcTZC7ZHp71IJEY9ynv/Lfn5jECkLeEaSa7e3LZiZCjoPXCuk95a/gpNGwnJ1MLVuvz4ohHe/KLAaj2/QOP1I3A3fc6Q27XK1019WhQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231023)(11241501184)(806099)(944501075)(10201501046)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:DB6PR0701MB2885;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB6PR0701MB2885; X-Forefront-PRVS: 0534947130 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(346002)(39860400002)(396003)(39380400002)(366004)(376002)(24454002)(189003)(199004)(16526018)(107886003)(6246003)(66066001)(50466002)(6486002)(7736002)(97736004)(83506002)(58126008)(76176011)(77096006)(5660300001)(65956001)(65806001)(65826007)(81156014)(53546011)(6116002)(8676002)(3846002)(81166006)(8936002)(2361001)(2906002)(36756003)(230700001)(4326008)(386003)(2351001)(53936002)(64126003)(31696002)(305945005)(47776003)(31686004)(6916009)(2950100002)(478600001)(16576012)(6666003)(229853002)(316002)(67846002)(86362001)(52146003)(68736007)(25786009)(106356001)(3260700006)(105586002)(2486003)(52116002)(23676004);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0701MB2885;H:[172.27.221.132];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA3MDFNQjI4ODU7MjM6cng1V3BIa1NpMEVPazV2THBxN0hzQU03?= =?utf-8?B?QUM3bEFYTXFjajUrSDd6TVJkVzBzZElJU1RrNG9tM0tXUlY3THdrSzlUdlZz?= =?utf-8?B?UmxBREJlQ1F5U3NpdHM3b2w3cUhuRUpyNWp1U21JbDNyTkp0b0pEL1ZFcDJB?= =?utf-8?B?UmJpSHB0OW9LS081ZUt6cGwraStMMlYyTUQ3OERZcUttVEFPUlB1YWpnMzU0?= =?utf-8?B?V2htbFhlMEtLUFJVTkZhSFkzY3JiaTFZZmUrRVFlelhMd0pRallQNXpMWTRU?= =?utf-8?B?WGswNDRHT3VIVVJQRGNjZmxMSzZEcEtSVll0NTFPd240dElyTnJtUlVQbDhj?= =?utf-8?B?OFJWc0tFaDcvL3lYVUtlbDdrUnlRUk1IazhzQWRaY1hQVXFxSGdUL1RGMGRE?= =?utf-8?B?bjZYQUtrWTVKOUZ5bGo0djlZWFdxT0t2UXJZVlE1Y1pWbEdzQ205ekNONGs2?= =?utf-8?B?KzVEaktxWlo1SW5nVDdqbWlMemNqbUhTUzFzSFBncTNNK1RjZ3J3U0VLb2hX?= =?utf-8?B?RTNKdFA2Q242UFBRc2llakhsZkZOZVhTWURpd1hlekM3QjFnYVhYOHdrelJU?= =?utf-8?B?YXJIbFZ4MFgrZFFCL3lKYk9OcTJlQVBwMk91dDNZTGVUVGxwN0Zma2lTeDZl?= =?utf-8?B?ZzdGNE9LazhPQU1wc3dYREFJU2pVL3FMRkw2SW9YRm9iNGhmRHVNY0NjTWt6?= =?utf-8?B?ZU5lajJhaHlVV1FFcTFKR2NMRG1FQTljZzBQRk5HZUxUNGhlL0RidHF5dFBz?= =?utf-8?B?VFJNNkkrZ3BlWG1yT3dLQnFPRmRPT0NPTVhKa0U5Q2FXRHZsZDVrNWg5SnUr?= =?utf-8?B?MzFNeTl6akdvN1ZzdUx3ZUhVWXRqeE1xM0V6dkxrK3NCNldjbk5CTGwwczVS?= =?utf-8?B?N2NvWjhLNmMzVzBtRVBzbHRMbVZGVHA5SC9lWk1jMnR1UUFNS1Q0blkrMk93?= =?utf-8?B?dFVxYnAwVGp0L3diL2NLTWtJTWxZQ2NEMGlBQ3JCS2k5U3J3cEZuMzZXSkph?= =?utf-8?B?V1NEclA2TTZ2QXk5TUpINGRxbUZhZFhlTWdjUkVHVmFqZms1bDhTRkNkaUQ0?= =?utf-8?B?OG43a3E2YWt6RkNLNEhQWmxtZ0VpRDIyclVMMU1xWDhmbFdndFJRK0dGVHJH?= =?utf-8?B?V0dOVXlJVGd5ZUg3WDJ1VW1rdkFNeFhoYnd5Z1JscXJWWUUwSGVTZFhiVHF6?= =?utf-8?B?VmxVak9tQ1JJYkVIbWE3U0dtWWFLbjdYdk1oMFNJM3YwUWdpL2R6NDlLQWtM?= =?utf-8?B?Ui90YlNwMVE2YzhjYVNuM3EvSWpVaHBmZ2lCTzlXQ3FRNXVBNHNoQjlpNGR2?= =?utf-8?B?emhNWWdBWnBEdjNBaERWV08wbFNKdDRSeUVNdzErVEpqSjljNkptb0pSY2ZD?= =?utf-8?B?TkZXKzB2dy84TlBQTVE4NWZCbHVRd1VXa3lFWEtTUFB2c0lrM1Z3QXNxR2Q1?= =?utf-8?B?R2RPZzVOYzlEVkRvd2x2S3Q3aW1jUTlNQU9lMzN3R2RJUzNoRGpDSW50UXUr?= =?utf-8?B?YjhCbGFtaUtLZlhNTkhYVEZLYi9vVi9LaXIycnlxTHpiSlFsR2JxaWJCTTVE?= =?utf-8?B?bWN4dWNjdnpCZExWSlY5OEo0THZ2bW9zMTA1d3BiR1R1OW9XKy9Ia2FCRUoy?= =?utf-8?B?SkVJRWNLV3N3NWV0OUEwK05rWE8vM1R3d1F4Qjh6SUlpNXdrYnNRc3E4N09m?= =?utf-8?B?MjVEZk8zdW5JazFkYnEzaGVkeEFXMXA0Mmp0V0ppZU03NHVkT0Y1T2JueTVk?= =?utf-8?B?d0dvdytVdWV6dXVueTQ3UFozaEZTSW9hTytDR1k3VS9uSjRzTkZvd3YyR2NZ?= =?utf-8?B?WWNXM3JBR3c2ZFhmL2hUSWxOcUVWSlhQQTBvSktsU1ZuZXVCWjQ2cThlSmE3?= =?utf-8?B?ajhTRE5WUnVjcXJIUW9UYWhtRGFwYVE5MWplWnVFcGZRNEJrdEU5WDdkTklN?= =?utf-8?B?Uy9kWDY2V3VhWFNoS0YrNDhpQUpPd0t2ZlpGUC9McHFxV1hFbFFhdi8yNy9r?= =?utf-8?Q?jVTNnsrw?= X-Microsoft-Antispam-Message-Info: RCQ38VuGpZTeFylWRYGXkNuU/aZRB+/dhUr0h7xX1P8KkZ/K8YB7T3NblHP2zsN2segXhAjzCvRfJ3JVRnZ5LA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2885;6:V8tE5/WTLHRQU0TP/Tw6nuVyZVu9ZEO1yxUN7bKCawUj4rqUSDk35bbC9c+GXGYmDc17avT2R4rdzTIgsyTmir8fWm9qkPk/nKwjOy926ObRUaReIeMJdW0FCP7vvd0Q4nli9iauJGk1PngzpftSh190wfRYh8xoWQPChg3no3fkZZcLdrewia3bU/X1TYnLlBLA9mvk92KLS/1E5Mug23zGtx/WnEpbXvTUlHwEFYObOvvtJAnCW/cvTjQcIrMNpUq1cdU2/xz+5kK0H3Wv07lXrrJ7ZKaU+9250MbnYBbnc9COoyd9uPqM+AgppAPHdQ7DnXAr4WOcvbtxafWejHyPZvmm5qoEB9xbw+cJx8c=;5:0hBo2xetwmbNxzMDrMfWK7L/cxCsQY7Yjr5BE8VJC0fcNIZvusHQOhsmF2XBxP+6507+6vnThq/+N13GGXnRMmpw1Z/0HiKwOtjvu+ZUh5VyskN9guUM1OpYdJShYeKRPZVilitxYOr+VbJxBy3lhpdSJMSpiAndnrw144pbFCM=;24:Gwr5T2g82WeUONoZu14Hdjg3uEuY2TE9ASMsYoEz1A36ZUivbUTY1BTta9SGj8lqj6jWTCFetopL8ZoVkJ9CKtj8Fw8a3FJFbfLeerwaOhQ=;7:b825NfnyOiOm21tfYbpwisOLk4zkAHTZpMm6rZyl7jeTgZ8PEJ1uBLI0p+3Un2vJU2TSfTerLtoJGtKOidu4/uxaMvfjqtbu2R54tLYGVfoDMwu6BPgfqkOmLW3LnYOHRNerZbbbBOo4AbMON0LQhx7136G8XXF41FcyIdSTx2KC6MNJoBR2NCSm1w0YJgKhIDIK07SC3x7V+5vHcx1QvySmeL69ykQE/89uhHW3jTEv2LPEt5IItiECPxz96zGi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2017 14:46:42.0952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f39b068-957f-41a6-4c4d-08d54d38a539 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2885 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 23 On 27/12/2017 14:58, Romain Porte wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 8bafd462f..18e826d36 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1050,6 +1050,8 @@ static const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256, > SECT_4K | SPI_NOR_DUAL_READ) }, > + { "is25lp080d", INFO(0x9d6014, 0, 64 * 1024, 16, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > Please note that the new SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ options have not been tested on our hardware for the moment. The Tested-by flag applies only for the previous configuration without these two new flags. We may be able to test these additional flags in the future, but they were added only from your (Cyrille's) review from previous patch. Please let me know if you want to wait for our hardware test results before merging into spi-nor/next, or if you are confident enough to merge it as this. Romain.