Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdL0Riv (ORCPT ); Wed, 27 Dec 2017 12:38:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50668 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdL0Rit (ORCPT ); Wed, 27 Dec 2017 12:38:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 04FBE60390 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 27 Dec 2017 09:38:46 -0800 From: Stephen Boyd To: Sean Wang Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, jdelvare@suse.de, jamesjj.liao@mediatek.com, weiyi.lu@mediatek.com, arnd@arndb.de, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c Message-ID: <20171227173846.GB7997@codeaurora.org> References: <20171227011021.GQ7997@codeaurora.org> <1514345580.30687.27.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514345580.30687.27.camel@mtkswgap22> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 49 On 12/27, Sean Wang wrote: > On Tue, 2017-12-26 at 17:10 -0800, Stephen Boyd wrote: > > On 12/25, sean.wang@mediatek.com wrote: > > > From: Sean Wang > > > > > > In fact, the clk-mtk.h header is indeed not needed for reset.c and thus > > > it's safe and good change to remove it from the file. > > > > > > Signed-off-by: Sean Wang > > > Reviewed-by: Jean Delvare > > > Cc: Jean Delvare > > > --- > > > drivers/clk/mediatek/reset.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c > > > index d3551d5..70ebb2e 100644 > > > --- a/drivers/clk/mediatek/reset.c > > > +++ b/drivers/clk/mediatek/reset.c > > > @@ -19,8 +19,6 @@ > > > #include > > > #include > > > > > > -#include "clk-mtk.h" > > > - > > > > drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static? > > > > It cannot be static since the function would be referenced in other > files under the same folder > > > One point I felt confused which is I didn't see the warning complains > when I did these build test, even I also added -Werror and -Wall to > build all files under driver/clk/mediatek. My toolchain is based on gcc > version 5.2.0 (GCC). > > > If the warning still is, the include "clk-mtk.h" should be good to stay > there because the declaration it needs is in the clk-mtk.h > The warning is from sparse. I built the file with C=2 on the commandline. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project