Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbdL0Uau (ORCPT ); Wed, 27 Dec 2017 15:30:50 -0500 Received: from home.regit.org ([37.187.126.138]:37744 "EHLO home.regit.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864AbdL0Uat (ORCPT ); Wed, 27 Dec 2017 15:30:49 -0500 Message-ID: <1514406645.31134.29.camel@regit.org> Subject: Re: [PATCH 3/4] libbpf: break loop earlier From: Eric Leblond To: Alexei Starovoitov Cc: netdev@vger.kernel.org, daniel@iogearbox.net, linux-kernel@vger.kernel.org Date: Wed, 27 Dec 2017 21:30:45 +0100 In-Reply-To: <20171227190042.hwxk6ccazdtnob77@ast-mbp> References: <20171227022730.y27gwva2u2ilyrul@ast-mbp> <20171227180229.1926-1-eric@regit.org> <20171227180229.1926-4-eric@regit.org> <20171227190042.hwxk6ccazdtnob77@ast-mbp> Organization: INL Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 36 Hello, On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote: > On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: > > Get out of the loop when we have a match. > > > > Signed-off-by: Eric Leblond > > --- > > tools/lib/bpf/libbpf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > > index 5fe8aaa2123e..d263748aa341 100644 > > --- a/tools/lib/bpf/libbpf.c > > +++ b/tools/lib/bpf/libbpf.c > > @@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object > > *obj) > > prog->section_name); > > return -LIBBPF_ERRNO__LIBELF; > > } > > + break; > > why this is needed? It was just cosmetic, no related bug. > The top of the loop is: > for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name; > > so as soon as name is found the loop will exit. OK, I've missed that. Please disregard this patch. BR, -- Eric Leblond