Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbdL0WYi (ORCPT ); Wed, 27 Dec 2017 17:24:38 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:48600 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbdL0WYh (ORCPT ); Wed, 27 Dec 2017 17:24:37 -0500 Date: Wed, 27 Dec 2017 22:24:01 +0000 From: Russell King - ARM Linux To: Antoine Tenart Cc: davem@davemloft.net, kishon@ti.com, andrew@lunn.ch, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface Message-ID: <20171227222401.GT10595@n2100.armlinux.org.uk> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-6-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171227221446.18459-6-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 37 On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > This patch enables the fourth network interface on the Marvell > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > Signed-off-by: Antoine Tenart > --- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > index b3350827ee55..c51efd511324 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > @@ -279,6 +279,14 @@ > phys = <&cps_comphy0 1>; > }; > > +&cps_eth2 { > + /* CPS Lane 5 */ > + status = "okay"; > + phy-mode = "2500base-x"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&cps_comphy5 2>; > +}; > + This is wrong. This lane is connected to a SFP cage which can support more than just 2500base-X. Tying it in this way to 2500base-X means that this port does not support conenctions at 1000base-X, despite that's one of the most popular and more standardised speeds. So, I feel I have to NAK this patch in its current form. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up