Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbdL1BFV (ORCPT ); Wed, 27 Dec 2017 20:05:21 -0500 Received: from out20-87.mail.aliyun.com ([115.124.20.87]:54333 "EHLO out20-87.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbdL1BFS (ORCPT ); Wed, 27 Dec 2017 20:05:18 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07449559|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03309;MF=yong.deng@magewell.com;NM=1;PH=DS;RN=25;RT=25;SR=0;TI=SMTPD_---.9wUn0gE_1514423097; Date: Thu, 28 Dec 2017 09:04:57 +0800 From: Yong To: Sakari Ailus Cc: maxime.ripard@free-electrons.com, Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , Greg Kroah-Hartman , "David S. Miller" , Hans Verkuil , Arnd Bergmann , Hugues Fruchet , Yannick Fertre , Philipp Zabel , Benoit Parrot , Benjamin Gaignard , Jean-Christophe Trotin , Ramesh Shanmugasundaram , Minghsiu Tsai , Krzysztof Kozlowski , Robert Jarzmik , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-Id: <20171228090457.c8911b0bd24bd24bf7f3a585@magewell.com> In-Reply-To: <20171227214723.rcssyay2lqqjf6ty@valkosipuli.retiisi.org.uk> References: <1501131697-1359-1-git-send-email-yong.deng@magewell.com> <1501131697-1359-3-git-send-email-yong.deng@magewell.com> <20171219115327.ofs5xwwimpn7x72n@valkosipuli.retiisi.org.uk> <20171221104935.663812085b616935ca3046de@magewell.com> <20171227214723.rcssyay2lqqjf6ty@valkosipuli.retiisi.org.uk> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4279 Lines: 141 Hi, On Wed, 27 Dec 2017 23:47:23 +0200 Sakari Ailus wrote: > Hi Yong, > > On Thu, Dec 21, 2017 at 10:49:35AM +0800, Yong wrote: > > Hi, > > > > On Tue, 19 Dec 2017 13:53:28 +0200 > > Sakari Ailus wrote: > > > > > Hi Yong, > > > > > > On Thu, Jul 27, 2017 at 01:01:36PM +0800, Yong Deng wrote: > > > > Add binding documentation for Allwinner V3s CSI. > > > > > > > > Signed-off-by: Yong Deng > > > > > > DT bindings should precede the driver. > > > > OK. > > > > > > > > > --- > > > > .../devicetree/bindings/media/sun6i-csi.txt | 49 ++++++++++++++++++++++ > > > > 1 file changed, 49 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > new file mode 100644 > > > > index 0000000..f8d83f6 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > @@ -0,0 +1,49 @@ > > > > +Allwinner V3s Camera Sensor Interface > > > > +------------------------------ > > > > + > > > > +Required properties: > > > > + - compatible: value must be "allwinner,sun8i-v3s-csi" > > > > > > What are sun6i and sun8i? Is this device first present in sun6i SoCs, > > > whereas you have only defined bindings for sun8i? > > > > Yes, some sun6i SoCs has the almost same CSI module. > > There is only V3s on my hand. So, I only tested it on V3s. But > > some people work on the others. > > Ack. > > > > > > > > > > + - reg: base address and size of the memory-mapped region. > > > > + - interrupts: interrupt associated to this IP > > > > + - clocks: phandles to the clocks feeding the CSI > > > > + * ahb: the CSI interface clock > > > > + * mod: the CSI module clock > > > > + * ram: the CSI DRAM clock > > > > + - clock-names: the clock names mentioned above > > > > + - resets: phandles to the reset line driving the CSI > > > > + > > > > +- ports: A ports node with endpoint definitions as defined in > > > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > > > > > Please document mandatory and optional endpoint properties relevant for the > > > hardware. > > > > I have added below commit in my v3: > > Currently, the driver only support the parallel interface. So, a single port > > node with one endpoint and parallel bus is supported. > > Please specify the exact properties that are relevant for the hardware. No > references should be made to the driver, the bindings are entirely > separate. > > Are the non-parallel (CSI-2?) and parallel bus on the same interface? If > yes, they should probably use different endpoints, if not, then different > ports. > > You could document the other bus or omit it now altogether, in which case > you'd only detail the parallel bus properties here. Thanks for your explication. I have misunderstood this. > > > > > > > > > > + > > > > +Example: > > > > + > > > > + csi1: csi@01cb4000 { > > > > + compatible = "allwinner,sun8i-v3s-csi"; > > > > + reg = <0x01cb4000 0x1000>; > > > > + interrupts = ; > > > > + clocks = <&ccu CLK_BUS_CSI>, > > > > + <&ccu CLK_CSI1_SCLK>, > > > > + <&ccu CLK_DRAM_CSI>; > > > > + clock-names = "ahb", "mod", "ram"; > > > > + resets = <&ccu RST_BUS_CSI>; > > > > + > > > > + port { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + /* Parallel bus endpoint */ > > > > + csi1_ep: endpoint { > > > > + remote-endpoint = <&adv7611_ep>; > > > > + bus-width = <16>; > > > > + data-shift = <0>; > > > > + > > > > + /* If hsync-active/vsync-active are missing, > > > > + embedded BT.656 sync is used */ > > > > + hsync-active = <0>; /* Active low */ > > > > + vsync-active = <0>; /* Active low */ > > > > + data-active = <1>; /* Active high */ > > > > + pclk-sample = <1>; /* Rising */ > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > > > -- > > > Kind regards, > > > > > > Sakari Ailus > > > e-mail: sakari.ailus@iki.fi > > > > > > Thanks, > > Yong > > -- > Regards, > > Sakari Ailus > e-mail: sakari.ailus@iki.fi Thanks, Yong