Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949AbdL1BFu (ORCPT ); Wed, 27 Dec 2017 20:05:50 -0500 Received: from out20-25.mail.aliyun.com ([115.124.20.25]:56382 "EHLO out20-25.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910AbdL1BFs (ORCPT ); Wed, 27 Dec 2017 20:05:48 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07655824|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03312;MF=yong.deng@magewell.com;NM=1;PH=DS;RN=23;RT=23;SR=0;TI=SMTPD_---.9wUj-85_1514423127; Date: Thu, 28 Dec 2017 09:05:27 +0800 From: Yong To: Rob Herring Cc: Maxime Ripard , Mauro Carvalho Chehab , Mark Rutland , Chen-Yu Tsai , "David S. Miller" , Greg Kroah-Hartman , Randy Dunlap , Hans Verkuil , Stanimir Varbanov , Hugues Fruchet , Yannick Fertre , Philipp Zabel , Arnd Bergmann , Benjamin Gaignard , Ramesh Shanmugasundaram , Sakari Ailus , Rick Chang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Message-Id: <20171228090527.59d207e03f08a81f51497b9c@magewell.com> In-Reply-To: <20171226215537.cmn4l7k2w764yrsg@rob-hp-laptop> References: <1513935689-35415-1-git-send-email-yong.deng@magewell.com> <20171226215537.cmn4l7k2w764yrsg@rob-hp-laptop> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2726 Lines: 92 Hi, On Tue, 26 Dec 2017 15:55:37 -0600 Rob Herring wrote: > On Fri, Dec 22, 2017 at 05:41:29PM +0800, Yong Deng wrote: > > Add binding documentation for Allwinner V3s CSI. > > > > Signed-off-by: Yong Deng > > --- > > .../devicetree/bindings/media/sun6i-csi.txt | 51 ++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > new file mode 100644 > > index 0000000..b5bfe3f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > @@ -0,0 +1,51 @@ > > +Allwinner V3s Camera Sensor Interface > > +------------------------------ > > + > > +Required properties: > > + - compatible: value must be "allwinner,sun8i-v3s-csi" > > + - reg: base address and size of the memory-mapped region. > > + - interrupts: interrupt associated to this IP > > + - clocks: phandles to the clocks feeding the CSI > > + * bus: the CSI interface clock > > + * mod: the CSI module clock > > + * ram: the CSI DRAM clock > > + - clock-names: the clock names mentioned above > > + - resets: phandles to the reset line driving the CSI > > + > > +- ports: A ports node with endpoint definitions as defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. > > + Currently, the driver only support the parallel interface. So, a single port > > + node with one endpoint and parallel bus is supported. > > What the driver supports is not relevant. Please document what the h/w > has. OK. > > > + > > +Example: > > + > > + csi1: csi@1cb4000 { > > + compatible = "allwinner,sun8i-v3s-csi"; > > + reg = <0x01cb4000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_CSI>, > > + <&ccu CLK_CSI1_SCLK>, > > + <&ccu CLK_DRAM_CSI>; > > + clock-names = "bus", "mod", "ram"; > > + resets = <&ccu RST_BUS_CSI>; > > + > > + port { > > > + #address-cells = <1>; > > + #size-cells = <0>; > > These are not needed with a single endpoint. OK. > > > + > > + /* Parallel bus endpoint */ > > + csi1_ep: endpoint { > > + remote-endpoint = <&adv7611_ep>; > > + bus-width = <16>; > > + data-shift = <0>; > > + > > + /* If hsync-active/vsync-active are missing, > > + embedded BT.656 sync is used */ > > + hsync-active = <0>; /* Active low */ > > + vsync-active = <0>; /* Active low */ > > + data-active = <1>; /* Active high */ > > + pclk-sample = <1>; /* Rising */ > > + }; > > + }; > > + }; > > + > > -- > > 1.8.3.1 > > Thanks, Yong