Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdL1Dms (ORCPT ); Wed, 27 Dec 2017 22:42:48 -0500 Received: from mail-ot0-f182.google.com ([74.125.82.182]:35164 "EHLO mail-ot0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbdL1Dmr (ORCPT ); Wed, 27 Dec 2017 22:42:47 -0500 X-Google-Smtp-Source: ACJfBouSIm+d/2ey5HG7KbZOvHHMNoAuQw56X3Y4yRNcDAItVDso0/OS4fGNSxfrRqne5t1FMtUiM+brt5/0rjlMUd8= MIME-Version: 1.0 In-Reply-To: <20171227173819.67iidrynd7jmmbmy@treble> References: <20171227173819.67iidrynd7jmmbmy@treble> From: Nick Desaulniers Date: Wed, 27 Dec 2017 22:42:45 -0500 Message-ID: Subject: Re: [PATCH] objtool: Fix clang enum conversion warning To: Josh Poimboeuf Cc: Lukas Bulwahn , Ingo Molnar , Linux Kernel Mailing List , Jiri Slaby , der.herr@hofr.at Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 16 On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf wrote: > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: >> Assuming that the authorship of this one-line change does not matter, as it >> is largely suggested by the clang compiler anyway, and we want to move the >> change forward, we should decide on which of three patches to move >> forward. I can give my Reviewed-by and Tested-by to any of them. I suppose Ingo would take the first and accumulate Reviewed-By tags. I don't particularly care about authorship (please just fix the bug). > The patch from Lukas was the first one I received, so that's the one I > used. I rewrote the commit msg for clarity and added my SOB and sent it > to Ingo for merging. I think you should have kept Nicholas Mc Guire's Reviewed by tag? Maybe Ingo can re-add his and mine when merging?