Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364AbdL1ETL (ORCPT ); Wed, 27 Dec 2017 23:19:11 -0500 Received: from mail-qt0-f179.google.com ([209.85.216.179]:42825 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840AbdL1ETJ (ORCPT ); Wed, 27 Dec 2017 23:19:09 -0500 X-Google-Smtp-Source: ACJfBovWS/QurQFHcNL0nOryLj7Nl8vy8TAvsy2Bi20nmRyRKJDlpfVz9h11Qp7PQerJVy59zEVNpA== Date: Wed, 27 Dec 2017 20:19:06 -0800 From: Jakub Kicinski To: Roman Gushchin Cc: , , , Alexei Starovoitov , Daniel Borkmann Subject: Re: [PATCH v3 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.9 Message-ID: <20171227201906.08e244bb@cakuba.netronome.com> In-Reply-To: <20171227191629.4920-2-guro@fb.com> References: <20171227191629.4920-1-guro@fb.com> <20171227191629.4920-2-guro@fb.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 16 On Wed, 27 Dec 2017 19:16:29 +0000, Roman Gushchin wrote: > Bpftool build is broken with binutils version 2.29 and later. > The cause is commit 003ca0fd2286 ("Refactor disassembler selection") > in the binutils repo, which changed the disassembler() function > signature. > > Fix this by adding a new "feature" to the tools/build/features > infrastructure and make it responsible for decision which > disassembler() function signature to use. > > Signed-off-by: Roman Gushchin > Cc: Jakub Kicinski > Cc: Alexei Starovoitov > Cc: Daniel Borkmann Acked-by: Jakub Kicinski