Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbdL1FML (ORCPT ); Thu, 28 Dec 2017 00:12:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54342 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdL1FMK (ORCPT ); Thu, 28 Dec 2017 00:12:10 -0500 Date: Wed, 27 Dec 2017 23:12:07 -0600 From: Josh Poimboeuf To: Nick Desaulniers Cc: Lukas Bulwahn , Ingo Molnar , Linux Kernel Mailing List , Jiri Slaby , der.herr@hofr.at Subject: Re: [PATCH] objtool: Fix clang enum conversion warning Message-ID: <20171228051207.zlbdyuwwaq52ff5q@treble> References: <20171227173819.67iidrynd7jmmbmy@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 28 Dec 2017 05:12:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 27 On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote: > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf wrote: > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: > >> Assuming that the authorship of this one-line change does not matter, as it > >> is largely suggested by the clang compiler anyway, and we want to move the > >> change forward, we should decide on which of three patches to move > >> forward. I can give my Reviewed-by and Tested-by to any of them. > > I suppose Ingo would take the first and accumulate Reviewed-By tags. > I don't particularly care about authorship (please just fix the bug). > > > The patch from Lukas was the first one I received, so that's the one I > > used. I rewrote the commit msg for clarity and added my SOB and sent it > > to Ingo for merging. > > I think you should have kept Nicholas Mc Guire's Reviewed by tag? > Maybe Ingo can re-add his and mine when merging? Yes, sorry, I missed that one. Ingo, can you please add the following? Reviewed-by: Nicholas Mc Guire Reviewed-by: Nick Desaulniers -- Josh