Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdL1HVN (ORCPT ); Thu, 28 Dec 2017 02:21:13 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47917 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbdL1HVM (ORCPT ); Thu, 28 Dec 2017 02:21:12 -0500 Date: Thu, 28 Dec 2017 08:20:53 +0100 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, linux@armlinux.org.uk, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum Message-ID: <20171228072053.GA27336@lunn.ch> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-2-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171227221446.18459-2-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 30 On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > This patch adds one more generic PHY mode to the phy_mode enum, to allow > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > callback. > > Signed-off-by: Antoine Tenart > --- > include/linux/phy/phy.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 4f8423a948d5..70459a28f3a1 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -28,6 +28,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE, > PHY_MODE_USB_OTG, > PHY_MODE_SGMII, > + PHY_MODE_SGMII_2_5G, > PHY_MODE_10GKR, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, Hi Antoine There was a discussion maybe last month about adding 2.5G SGMII. I would prefer 2500SGMII. Putting the number first makes it uniform with the other defines, 1000BASEX, 25000BASEX, 10GKR. Andrew