Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbdL1KHL (ORCPT ); Thu, 28 Dec 2017 05:07:11 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:45590 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885AbdL1KHJ (ORCPT ); Thu, 28 Dec 2017 05:07:09 -0500 Date: Thu, 28 Dec 2017 11:06:57 +0100 From: Antoine Tenart To: Andrew Lunn Cc: Antoine Tenart , davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, linux@armlinux.org.uk, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum Message-ID: <20171228100656.GF2626@kwain> References: <20171227221446.18459-1-antoine.tenart@free-electrons.com> <20171227221446.18459-2-antoine.tenart@free-electrons.com> <20171228072053.GA27336@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171228072053.GA27336@lunn.ch> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 41 Hi Andrew, On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > > This patch adds one more generic PHY mode to the phy_mode enum, to allow > > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > > callback. > > > > Signed-off-by: Antoine Tenart > > --- > > include/linux/phy/phy.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > index 4f8423a948d5..70459a28f3a1 100644 > > --- a/include/linux/phy/phy.h > > +++ b/include/linux/phy/phy.h > > @@ -28,6 +28,7 @@ enum phy_mode { > > PHY_MODE_USB_DEVICE, > > PHY_MODE_USB_OTG, > > PHY_MODE_SGMII, > > + PHY_MODE_SGMII_2_5G, > > PHY_MODE_10GKR, > > PHY_MODE_UFS_HS_A, > > PHY_MODE_UFS_HS_B, > > There was a discussion maybe last month about adding 2.5G SGMII. I > would prefer 2500SGMII. Putting the number first makes it uniform with > the other defines, 1000BASEX, 25000BASEX, 10GKR. Good to know. I wasn't completely sure how to name this mode properly, but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a v2 (without the dt part). Thanks! Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com