Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212AbdL1MJu (ORCPT ); Thu, 28 Dec 2017 07:09:50 -0500 Received: from mail-wr0-f175.google.com ([209.85.128.175]:43051 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbdL1MJt (ORCPT ); Thu, 28 Dec 2017 07:09:49 -0500 X-Google-Smtp-Source: ACJfBovgf69W4+vi3wCwYKBSHHQyqeGFdBQClUlaaw2j0FP4NsmYbwB1yffE3QsxgFuot9p7GZjVvw== Date: Thu, 28 Dec 2017 13:09:45 +0100 From: Ingo Molnar To: Josh Poimboeuf Cc: Nick Desaulniers , Lukas Bulwahn , Linux Kernel Mailing List , Jiri Slaby , der.herr@hofr.at Subject: Re: [PATCH] objtool: Fix clang enum conversion warning Message-ID: <20171228120945.qppd7o7jpchbpxuu@gmail.com> References: <20171227173819.67iidrynd7jmmbmy@treble> <20171228051207.zlbdyuwwaq52ff5q@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171228051207.zlbdyuwwaq52ff5q@treble> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 33 * Josh Poimboeuf wrote: > On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote: > > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf wrote: > > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: > > >> Assuming that the authorship of this one-line change does not matter, as it > > >> is largely suggested by the clang compiler anyway, and we want to move the > > >> change forward, we should decide on which of three patches to move > > >> forward. I can give my Reviewed-by and Tested-by to any of them. > > > > I suppose Ingo would take the first and accumulate Reviewed-By tags. > > I don't particularly care about authorship (please just fix the bug). > > > > > The patch from Lukas was the first one I received, so that's the one I > > > used. I rewrote the commit msg for clarity and added my SOB and sent it > > > to Ingo for merging. > > > > I think you should have kept Nicholas Mc Guire's Reviewed by tag? > > Maybe Ingo can re-add his and mine when merging? > > Yes, sorry, I missed that one. > > Ingo, can you please add the following? > > Reviewed-by: Nicholas Mc Guire > Reviewed-by: Nick Desaulniers Sure, done! Thanks, Ingo