Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbdL1MwN (ORCPT ); Thu, 28 Dec 2017 07:52:13 -0500 Received: from mail-it0-f49.google.com ([209.85.214.49]:34090 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbdL1MwL (ORCPT ); Thu, 28 Dec 2017 07:52:11 -0500 X-Google-Smtp-Source: ACJfBouW9uocN7KAdGBiWSyXwOtX80BBoraPQ7/ATYjGgL5Cs+kD4uO7BZnpWMdEG/1oZ8YGmww+0P1XvIWm/B9TFhA= MIME-Version: 1.0 In-Reply-To: <20171228043312.GA11117@sophia> References: <309acd17-5244-da8c-a28e-dace15ada4fb@maciej.szmigiero.name> <20171224224215.GA2372@sophia> <0e8ece1e-3041-ea58-f5b6-298c163fa747@maciej.szmigiero.name> <20171227002410.GA12050@sophia> <20171228043312.GA11117@sophia> From: Linus Walleij Date: Thu, 28 Dec 2017 13:52:10 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: winbond: add driver To: William Breathitt Gray Cc: "Maciej S. Szmigiero" , Andy Shevchenko , Jonathan Cameron , linux-kernel , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 716 Lines: 20 On Thu, Dec 28, 2017 at 5:33 AM, William Breathitt Gray wrote: > Given that CONFIG_PC104 now fulfills the original purpose of adding > ISA_BUS_API to the depends on line for the PC/104 device drivers, and > that ISA_BUS_API can be selected as necessary with no danger to the > integrity of the system, I think it would be appropriate to change all > the existing ISA_BUS_API depends on lines to respective select lines. > Does that logic make sense? I'm *BAD* at Kconfig. But it makes sense to me. I just suspect that if you turn these into selects, you will see the same thing that Maciej is seeing and then you get to deal with it :D So by all means, try it out! Yours, Linus Walleij