Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbdL1N5g (ORCPT ); Thu, 28 Dec 2017 08:57:36 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47846 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753597AbdL1N5c (ORCPT ); Thu, 28 Dec 2017 08:57:32 -0500 Date: Thu, 28 Dec 2017 14:57:20 +0100 From: Alexandre Belloni To: Rob Herring Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Philippe Ombredanne , =?iso-8859-1?B?VPxyayw=?= Jan , Mark Rutland , Thierry Reding , David Airlie , Russell King , Shawn Guo , Sascha Hauer , Fabio Estevam , Kevin Hilman , Maxime Ripard , SZ Lin , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , LinuxArmKernelMailingListe Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Message-ID: <20171228135720.GL18255@piout.net> References: <95F51F4B902CAC40AF459205F6322F01B7FDFECC3C@BMK019S01.emtrion.local> <20171222104028.GC18255@piout.net> <20171222105642.GD18255@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 48 On 26/12/2017 at 11:16:34 -0600, Rob Herring wrote: > On Fri, Dec 22, 2017 at 4:56 AM, Alexandre Belloni > wrote: > > + Philippe > > > > On 22/12/2017 at 11:43:33 +0100, Andreas F?rber wrote: > >> >> I'll change it for v3 of this patch however it will end up like this: > >> >> //SPDX-License... > >> > > >> > That should be /* SPDX-License */, // is for c files. > >> > >> Got any reference for that? Since we're using the C preprocessor before > >> feeding them to dtc, we can use the same // style for both, builds fine. > >> > >> Only for my private DT overlay files that I use directly with dtc I > >> couldn't adopt that style. > > We are well past the point of being able to build most dts files with just dtc. > > > The doc states: > > > > If a specific tool cannot handle the standard comment style, then the > > appropriate comment mechanism which the tool accepts shall be used. This > > is the reason for having the "/\* \*/" style comment in C header > > files. > > > > I interpreted that as dtc doesn't handle // comments, use /**/ > > It's been so long, I'd forgotten that. Perhaps we should fix dtc to > handle // comments. > The would probably be the best solution so we get a somewhat consistent style before people start moving the existing SDPX identifiers to the top of their dtsi/dts files. > > > > But I agree it also states: > > .dts{i}: // SPDX-License-Identifier: > > Or we could still change this. The guidelines aren't merged yet. > > Rob -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com