Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbdL1PVf (ORCPT ); Thu, 28 Dec 2017 10:21:35 -0500 Received: from mga03.intel.com ([134.134.136.65]:60255 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454AbdL1PVe (ORCPT ); Thu, 28 Dec 2017 10:21:34 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,471,1508828400"; d="scan'208";a="15752326" Message-ID: <1514474310.7000.420.camel@linux.intel.com> Subject: Re: [PATCH v2] gpio: winbond: add driver From: Andy Shevchenko To: "Maciej S. Szmigiero" , Linus Walleij Cc: William Breathitt Gray , linux-kernel , linux-gpio@vger.kernel.org Date: Thu, 28 Dec 2017 17:18:30 +0200 In-Reply-To: <309acd17-5244-da8c-a28e-dace15ada4fb@maciej.szmigiero.name> References: <309acd17-5244-da8c-a28e-dace15ada4fb@maciej.szmigiero.name> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 398 Lines: 12 On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. Linus, since you asked me to review this, I can conclude that it is a bit far from readiness. Couple of more iterations needed. Please, also answer to a comment in review in regard to gpio_valid_mask use. -- Andy Shevchenko Intel Finland Oy