Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925AbdL1PmA (ORCPT ); Thu, 28 Dec 2017 10:42:00 -0500 Received: from terminus.zytor.com ([65.50.211.136]:43799 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbdL1Pl7 (ORCPT ); Thu, 28 Dec 2017 10:41:59 -0500 Date: Thu, 28 Dec 2017 07:37:25 -0800 From: tip-bot for Lukas Bulwahn Message-ID: Cc: hpa@zytor.com, mingo@kernel.org, torvalds@linux-foundation.org, der.herr@hofr.at, peterz@infradead.org, jslaby@suse.cz, nick.desaulniers@gmail.com, lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, jpoimboe@redhat.com Reply-To: peterz@infradead.org, hpa@zytor.com, mingo@kernel.org, torvalds@linux-foundation.org, der.herr@hofr.at, jslaby@suse.cz, nick.desaulniers@gmail.com, lukas.bulwahn@gmail.com, tglx@linutronix.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:core/urgent] objtool: Fix Clang enum conversion warning Git-Commit-ID: e7e83dd3ff1dd2f9e60213f6eedc7e5b08192062 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1904 Lines: 49 Commit-ID: e7e83dd3ff1dd2f9e60213f6eedc7e5b08192062 Gitweb: https://git.kernel.org/tip/e7e83dd3ff1dd2f9e60213f6eedc7e5b08192062 Author: Lukas Bulwahn AuthorDate: Tue, 26 Dec 2017 15:27:20 -0600 Committer: Ingo Molnar CommitDate: Thu, 28 Dec 2017 13:11:13 +0100 objtool: Fix Clang enum conversion warning Fix the following Clang enum conversion warning: arch/x86/decode.c:141:20: error: implicit conversion from enumeration type 'enum op_src_type' to different enumeration type 'enum op_dest_type' [-Werror,-Wenum-conversion] op->dest.type = OP_SRC_REG; ~ ^~~~~~~~~~ It just happened to work before because OP_SRC_REG and OP_DEST_REG have the same value. Signed-off-by: Lukas Bulwahn Signed-off-by: Josh Poimboeuf Reviewed-by: Nicholas Mc Guire Reviewed-by: Nick Desaulniers Cc: Jiri Slaby Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: baa41469a7b9 ("objtool: Implement stack validation 2.0") Link: http://lkml.kernel.org/r/b4156c5738bae781c392e7a3691aed4514ebbdf2.1514323568.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- tools/objtool/arch/x86/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c index 8acfc47..540a209 100644 --- a/tools/objtool/arch/x86/decode.c +++ b/tools/objtool/arch/x86/decode.c @@ -138,7 +138,7 @@ int arch_decode_instruction(struct elf *elf, struct section *sec, *type = INSN_STACK; op->src.type = OP_SRC_ADD; op->src.reg = op_to_cfi_reg[modrm_reg][rex_r]; - op->dest.type = OP_SRC_REG; + op->dest.type = OP_DEST_REG; op->dest.reg = CFI_SP; } break;