Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751290AbdL1QOz (ORCPT ); Thu, 28 Dec 2017 11:14:55 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:41603 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdL1QOx (ORCPT ); Thu, 28 Dec 2017 11:14:53 -0500 X-Google-Smtp-Source: ACJfBosvcoMyR9Ks3tz9gwzB/ZajioBZ0rO5LptC5+g7Qasfwpffsez94j2KkOHZhihV3XTaXgLszOvdZYX5ZUd4S/Q= MIME-Version: 1.0 In-Reply-To: <297161514451589@web50o.yandex.ru> References: <001a11421c7436e541055c4c7cf0@google.com> <1164631514405294@web52j.yandex.ru> <926421514406019@web43j.yandex.ru> <297161514451589@web50o.yandex.ru> From: Tom Herbert Date: Thu, 28 Dec 2017 08:14:51 -0800 Message-ID: Subject: Re: WARNING in strp_data_ready To: Ozgur Cc: Dmitry Vyukov , John Fastabend , syzbot , "David S. Miller" , Eric Biggers , LKML , Linux Kernel Network Developers , "syzkaller-bugs@googlegroups.com" , Tom Herbert , Cong Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2518 Lines: 63 On Thu, Dec 28, 2017 at 12:59 AM, Ozgur wrote: > > > 28.12.2017, 04:19, "Tom Herbert" : >> On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote: >>> 27.12.2017, 23:14, "Dmitry Vyukov" : >>>> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote: >>>>> 27.12.2017, 22:21, "Dmitry Vyukov" : >>>>>> On Wed, Dec 27, 2017 at 8:09 PM, Tom Herbert wrote: >>>>>>> Did you try the patch I posted? >>>>>> >>>>>> Hi Tom, >>>>> >>>>> Hello Dmitry, >>>>> >>>>>> No. And I didn't know I need to. Why? >>>>>> If you think the patch needs additional testing, you can ask syzbot to >>>>>> test it. See https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot >>>>>> Otherwise proceed with committing it. Or what are we waiting for? >>>>>> >>>>>> Thanks >>>>> >>>>> I think we need to fixed patch for crash, in fact check to patch code and test solve the bug. >>>>> How do test it because there is no patch in the following bug? >>>> >>>> Hi Ozgur, >>>> >>>> I am not sure I completely understand what you mean. But the >>>> reproducer for this bug (which one can use for testing) is here: >>>> https://groups.google.com/forum/#!topic/syzkaller-bugs/Kxs05ziCpgY >>>> Tom also mentions there is some patch for this, but I don't know where >>>> it is, it doesn't seem to be referenced from this thread. >>> >>> Hello Dmitry, >>> >>> Ah, I'm sorry I don't seen Tom mail and I don't have a patch not tested :) >>> I think Tom send patch to only you and are you tested? >>> >>> kcmsock.c will change and strp_data_ready I think locked. >>> >>> Tom, please send a patch for me? I can test and inform you. >> >> Hi Ozgur, >> >> I reposted the patches as RFC "kcm: Fix lockdep issue". Please test if you can! >> >> Thanks, >> Tom > > Hello Tom, > > Which are you use the repos? I pulled but I don't seen this patches. > They are not in any public repo yet. I posted the patches to netdev list so they can be reviewed and tested by third parties. Posting patches to the list a normal path to get patches into the kernel (http://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/). These patches were applied to net-next but are simple enough that they should apply to other branches. I will repost and target to net per Dave's directive once they are verified to fix the issue. Tom