Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422AbdL1RYO (ORCPT ); Thu, 28 Dec 2017 12:24:14 -0500 Received: from mail-ua0-f193.google.com ([209.85.217.193]:34773 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754416AbdL1RYK (ORCPT ); Thu, 28 Dec 2017 12:24:10 -0500 X-Google-Smtp-Source: ACJfBos5vo5MQZEfA0k8U5ibpAuqsq7fwxGUkdludoRFRM25F43Lb07H7/ROasWlS+MzLulhZ/eUBMCe5uESJo5xOH4= MIME-Version: 1.0 In-Reply-To: <20171228121509.wq7mdeh3v4jcbjn2@gmail.com> References: <20171226140922.16699-1-malat@debian.org> <20171228121509.wq7mdeh3v4jcbjn2@gmail.com> From: Mathieu Malaterre Date: Thu, 28 Dec 2017 18:23:48 +0100 X-Google-Sender-Auth: cw6bwx9Yf4DKtG8_9SqhYQDXUCI Message-ID: Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration To: Ingo Molnar Cc: Ard Biesheuvel , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBSHOHeU001096 Content-Length: 711 Lines: 22 Hi Ingo, On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar wrote: > > * Mathieu Malaterre wrote: > >> Fix non-fatal warnings such as: >> >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] >> static int __always_inline >> ^~~~~~ >> >> Signed-off-by: Mathieu Malaterre >> --- >> kernel/events/ring_buffer.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Hm, never saw this warning before - is this a newly default GCC warning, or some > distro CFLAGS build that enables it? Nope. Just compiling vanilla kernel with default options, defconfig was pmac32. I used W=1.