Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbdL1SWV (ORCPT ); Thu, 28 Dec 2017 13:22:21 -0500 Received: from shells.gnugeneration.com ([66.240.222.126]:56974 "EHLO shells.gnugeneration.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbdL1SWR (ORCPT ); Thu, 28 Dec 2017 13:22:17 -0500 Date: Thu, 28 Dec 2017 10:30:11 -0800 From: vcaputo@pengaru.com To: Thomas Gleixner Cc: Pavel Machek , linux-kernel Subject: Re: thinkpad x60: sound problems in 4.15-rc1 was Re: thinkpad x60: sound problems in 4.14.0-next-20171114 Message-ID: <20171228183011.oy3sazkxe2bgyjvl@shells.gnugeneration.com> References: <20171219045415.46croaosad656d5v@shells.gnugeneration.com> <20171219231256.dpizizz55o27op3s@shells.gnugeneration.com> <20171219232212.GA5177@amd> <20171220003610.vogk3wrke47drsfw@shells.gnugeneration.com> <20171223053700.xu2fdir32e4e6cd6@shells.gnugeneration.com> <20171223203741.q4hwq6i33cjf3dyg@shells.gnugeneration.com> <20171224161601.cu6kr74cfckfxkj3@shells.gnugeneration.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2199 Lines: 64 On Thu, Dec 28, 2017 at 11:41:45AM +0100, Thomas Gleixner wrote: > On Sun, 24 Dec 2017, vcaputo@pengaru.com wrote: > > On Sat, Dec 23, 2017 at 09:33:37PM +0100, Thomas Gleixner wrote: > > > > It seems like the affinity changes are assuming a strict adherence to > > > > the CPU mask when the underlying hardware is treating it more as a hint. > > > > Perhaps handlers still need to be maintained on all CPUs in a given apic > > > > domain, regardless of what the masks are configured as, to cover these > > > > situations. > > > > > > That's odd. I'll have a look after the holidays. > > > > > > > Ok, just FYI I've reproduced it on rc5 as well. > > > > I may be offline a bit at the start of the new year, in case you've got > > something for me to test and I'm unresponsive. > > Can you try the patch below? > Looks fixed so far, I'll try living in 4.15-rc5 now and will report back if anything goes sideways. Thanks Thomas! > Thanks, > > tglx > > 8<--------------- > --- a/arch/x86/kernel/apic/apic_flat_64.c > +++ b/arch/x86/kernel/apic/apic_flat_64.c > @@ -151,7 +151,7 @@ static struct apic apic_flat __ro_after_ > .apic_id_valid = default_apic_id_valid, > .apic_id_registered = flat_apic_id_registered, > > - .irq_delivery_mode = dest_LowestPrio, > + .irq_delivery_mode = dest_Fixed, > .irq_dest_mode = 1, /* logical */ > > .disable_esr = 0, > --- a/arch/x86/kernel/apic/probe_32.c > +++ b/arch/x86/kernel/apic/probe_32.c > @@ -105,7 +105,7 @@ static struct apic apic_default __ro_aft > .apic_id_valid = default_apic_id_valid, > .apic_id_registered = default_apic_id_registered, > > - .irq_delivery_mode = dest_LowestPrio, > + .irq_delivery_mode = dest_Fixed, > /* logical delivery broadcast to all CPUs: */ > .irq_dest_mode = 1, > > --- a/arch/x86/kernel/apic/x2apic_cluster.c > +++ b/arch/x86/kernel/apic/x2apic_cluster.c > @@ -184,7 +184,7 @@ static struct apic apic_x2apic_cluster _ > .apic_id_valid = x2apic_apic_id_valid, > .apic_id_registered = x2apic_apic_id_registered, > > - .irq_delivery_mode = dest_LowestPrio, > + .irq_delivery_mode = dest_Fixed, > .irq_dest_mode = 1, /* logical */ > > .disable_esr = 0,