Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754535AbdL1XUB (ORCPT ); Thu, 28 Dec 2017 18:20:01 -0500 Received: from forward2j.cmail.yandex.net ([5.255.227.20]:54462 "EHLO forward2j.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754445AbdL1XUA (ORCPT ); Thu, 28 Dec 2017 18:20:00 -0500 Authentication-Results: mxback6j.mail.yandex.net; dkim=pass header.i=@yandex.com.tr From: Ozgur Envelope-From: okaratas@yandex.com.tr To: Philippe Loctaux , "gregkh@linuxfoundation.org" Cc: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <20171228230650.12973-3-loctauxphilippe@gmail.com> References: <20171228230650.12973-1-loctauxphilippe@gmail.com> <20171228230650.12973-3-loctauxphilippe@gmail.com> Subject: Re: [PATCH 2/2] Staging: most: aim-sound: sound.c: removed unnecessary parentheses MIME-Version: 1.0 Message-Id: <227541514503196@web8o.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 29 Dec 2017 02:19:56 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 31 29.12.2017, 02:07, "Philippe Loctaux" : > Removed unnecessary parentheses in a if statement. > > Signed-off-by: Philippe Loctaux > --- >  drivers/staging/most/aim-sound/sound.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c > index ab2b0d833..0e79a4898 100644 > --- a/drivers/staging/most/aim-sound/sound.c > +++ b/drivers/staging/most/aim-sound/sound.c > @@ -166,7 +166,7 @@ static struct channel *get_channel(struct most_interface *iface, >          struct channel *channel, *tmp; > >          list_for_each_entry_safe(channel, tmp, &dev_list, list) { > - if ((channel->iface == iface) && (channel->id == channel_id)) > + if (channel->iface == iface && channel->id == channel_id) >                          return channel; >          } Hello, I think this patch is not good, the code will not work. Please should understand in && operator and () why used with C. Ozgur > -- > 2.15.1